Skip to content

Rename version constant and reenable release version validation #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
praveek merged 2 commits into from
Feb 11, 2025
Merged

Rename version constant and reenable release version validation #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6747724
Rename EXTENSION_VERSION to VERSION
timkimadobe Feb 11, 2025
01933b5
Reenable constants file validation for release workflow
timkimadobe Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/maven-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ jobs:
with:
tag: ${{ github.event.inputs.tag }}
create-github-release: ${{ github.event.inputs.create-github-release == 'true' }}
version-validation-paths: code/gradle.properties
version-validation-paths: code/gradle.properties, code/analytics/src/main/java/com/adobe/marketing/mobile/analytics/internal/AnalyticsConstants.kt
version-validation-dependencies: Core ${{ github.event.inputs.core-dependency }}
secrets: inherit
2 changes: 1 addition & 1 deletion ...alytics/src/main/java/com/adobe/marketing/mobile/analytics/internal/AnalyticsConstants.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ internal object AnalyticsConstants {

const val EXTENSION_NAME = "com.adobe.module.analytics"
const val FRIENDLY_NAME = "Analytics"
const val EXTENSION_VERSION = "3.0.2"
const val VERSION = "3.0.2"
const val DATASTORE_NAME = "AnalyticsDataStorage"
const val DATA_QUEUE_NAME = EXTENSION_NAME
const val REORDER_QUEUE_NAME = "com.adobe.module.analyticsreorderqueue"
Expand Down
2 changes: 1 addition & 1 deletion ...alytics/src/main/java/com/adobe/marketing/mobile/analytics/internal/AnalyticsExtension.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ internal class AnalyticsExtension : Extension {
}

override fun getVersion(): String {
return AnalyticsConstants.EXTENSION_VERSION
return AnalyticsConstants.VERSION
}

/**
Expand Down
2 changes: 1 addition & 1 deletion .../test/java/com/adobe/marketing/mobile/analytics/internal/AnalyticsExtensionVersionTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class AnalyticsExtensionVersionTest {

@Test
fun internalExtensionVersion_publicExtensionVersion_asEqual() {
assertEquals(AnalyticsConstants.EXTENSION_VERSION, Analytics.extensionVersion())
assertEquals(AnalyticsConstants.VERSION, Analytics.extensionVersion())
}

@Test
Expand Down
Loading