Skip to content

Rename version constant and reenable release version validation#101

Merged
praveek merged 2 commits intoadobe:devfrom
timkimadobe:fix-ci-setup
Feb 11, 2025
Merged

Rename version constant and reenable release version validation#101
praveek merged 2 commits intoadobe:devfrom
timkimadobe:fix-ci-setup

Conversation

@timkimadobe
Copy link
Contributor

Description

This PR renames the extension version variable from EXTENSION_VERSION -> VERSION to align with the regex used for .kt files by default for version update/validation.

It also reenables validation of the version in the constants file as part of the release workflow.

See example version job here:

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@timkimadobe timkimadobe requested a review from praveek February 11, 2025 04:31
@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.56%. Comparing base (dc2a155) to head (01933b5).
Report is 61 commits behind head on dev.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev     #101       +/-   ##
=============================================
+ Coverage     78.92%   90.56%   +11.63%     
- Complexity      286      324       +38     
=============================================
  Files            15       15               
  Lines          1514     1590       +76     
  Branches        184      182        -2     
=============================================
+ Hits           1195     1440      +245     
+ Misses          222       82      -140     
+ Partials         97       68       -29     
Flag Coverage Δ
android-functional-tests 35.66% <100.00%> (?)
android-unit-tests 90.56% <100.00%> (?)
unit-functional-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@praveek praveek changed the base branch from main to dev February 11, 2025 21:36
@praveek praveek merged commit ee36bad into adobe:dev Feb 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants