Skip to content

Device list not guaranteed to place front camera at index 0 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karlmorris wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Device list not guaranteed to place front camera at index 0 #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/com/addlive/sampleapp/AddLiveSampleApp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,8 +658,6 @@ private void onPublishError(int errCode, String errMessage) {
// ===========================================================================

private void onGetVideoCaptureDeviceNames(List<Device> devices) {
int index = 0;

// set camera device names in camera selection spinner
String[] devs = new String[devices.size()];
int i = 0;
Expand All @@ -676,7 +674,9 @@ private void onGetVideoCaptureDeviceNames(List<Device> devices) {
Spinner spinner = (Spinner) findViewById(R.id.spinner_camera);
spinner.setOnItemSelectedListener(new CameraSelectionListener(devices));
spinner.setAdapter(adapter);
spinner.setSelection(index); // select front camera if available
int frontCameraSpinnerIndex = ((ArrayAdapter<CharSequence>)spinner.getAdapter())
.getPosition("Front Camera") == 1 ? 1 : 0;
spinner.setSelection(frontCameraSpinnerIndex); // select front camera if available

// start video preview
ADL.getService().startLocalVideo(new UIThreadResponder<String>(this) {
Expand Down