Device list not guaranteed to place front camera at index 0#1
Open
karlmorris wants to merge 1 commit intoaddlive:masterfrom
karlmorris:master
Open
Device list not guaranteed to place front camera at index 0#1karlmorris wants to merge 1 commit intoaddlive:masterfrom karlmorris:master
karlmorris wants to merge 1 commit intoaddlive:masterfrom
karlmorris:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default value 0 is not guaranteed to be the front facing camera on devices that contain 2 cameras (tested on Nexus 4 and Nexus 7 2013; both running Android 4.4.2). This code checks for the front camera label at index 1, and defaults to index 0 if it fails. This is safe for devices with 1 or 2 cameras.