Disable interrupts before jumping to diagnostics rom #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooinglemur
approved these changes
Dec 27, 2025
Collaborator
|
Thanks! |
Contributor
Author
|
Oh... the reason this worked for R48 seem to be that the location of the sei instruction was moved in PR #424 . That PR seem to have moved the sei instruction to be executed earlier during a long power-on startup, while this seem to have caused sei to not be executed at all when loaded via the C000 jump table. @jburks FYI. Maybe the cleanest fix would be to reintroduce the original "sei" from before #424 (or at least somewhere along the path when using the jump table), while also having the new "sei" from #424 ? |
stople
added a commit
to stople/x16-rom
that referenced
this pull request
Dec 27, 2025
Fixes a bug introduced in X16Community#424 . Also reverts the redundant fix done in X16Community#449 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to start diagnostics rom from menu. With reference to report in "x16-general" today.
This ensures that vblank interrupt does not crash the machine when ISR is overwritten by memory test.