Always disable interrupts when starting diagnostics rom via jump table #450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diag rom can be started in two ways:
Before #424 , both these ways of starting the diagnostics tool would disable interrupts.
#424 moved the SEI instruction, to be performed earlier when doing a long power-on start. However, this also caused that start via the jump table did not perform SEI.
This PR reintroduces the SEI removed in 424, while keeping the additional SEI that is done early, which should be a proper fix of this introduced bug.
Also reverts a redundant fix done in #449 .
This also makes it possible to start the diag rom using