Skip to content

wpdb: catch mysqli exceptions in _do_query() #10750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
solankisoftware89 wants to merge 1 commit into
base: trunk
Choose a base branch
from
+6 −1
Open

wpdb: catch mysqli exceptions in _do_query() #10750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/wp-includes/class-wpdb.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2348,7 +2348,12 @@
}

if ( ! empty( $this->dbh ) ) {
$this->result = mysqli_query( $this->dbh, $query );
try {

Check failure on line 2351 in src/wp-includes/class-wpdb.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Tabs must be used to indent lines; spaces are not allowed
$this->result = mysqli_query( $this->dbh, $query );

Check failure on line 2352 in src/wp-includes/class-wpdb.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Tabs must be used to indent lines; spaces are not allowed
} catch ( Exception $e ) {

Check failure on line 2353 in src/wp-includes/class-wpdb.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Tabs must be used to indent lines; spaces are not allowed
$this->result = false;

Check failure on line 2354 in src/wp-includes/class-wpdb.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Tabs must be used to indent lines; spaces are not allowed
$this->last_error = $e->getMessage();

Check failure on line 2355 in src/wp-includes/class-wpdb.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Tabs must be used to indent lines; spaces are not allowed
}

Check failure on line 2356 in src/wp-includes/class-wpdb.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Tabs must be used to indent lines; spaces are not allowed
}

++$this->num_queries;
Expand Down
Loading