useBlockControlsFill: avoid unneeded store subscriptions #55340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Performance
|
Size Change: 0 B Total Size: 1.65 MB ℹ️ View Unchanged
|
tyxla
approved these changes
Oct 13, 2023
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Nice find 👍
It's a pretty straightforward change and I'm fairly confident it's safe.
While it doesn't bring amazing perf improvements, it's still a nice little one.
Thanks 🚀
tyxla
reviewed
Oct 17, 2023
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Something that came up while discussing these kinds of optimizations is that it could be worth adding a comment to describe what we're doing. Otherwise, it could be very easy to lose this optimization in a refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a block renders a
<BlockControls>markup, its contents are rendered in the slot only if the block is selected. TheuseBlockControlsFillensures that, returning a non-null fill only when the block is selected.This PR optimizes the
useBlockControlsFillhook: ifshareWithChildBlocksis false, it can return early without creating any subscriptions to theblock-editorstore. And reducing number of subscriptions helps fix #54819.On a large post with 1000 blocks, I'm seeing (using the debug code from #55337) a reduction by 1500 subscriptions, from 77.5k to 76k.