Block Editor: Optimize 'customClassName' controls #55345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.39 kB (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
try/optimize-custom-class-name-controls
branch
from
8f0e7d6 to
171f92d
Compare
|
Flaky tests detected in 8f0e7d61d6fe43dae59fe481bf39f6a268ecd50f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6508289897
|
Member
Author
jsnajdr
approved these changes
Oct 16, 2023
Member
jsnajdr
left a comment
jsnajdr
left a comment
There was a problem hiding this comment.
Thanks, simple and effective 🙂
tyxla
approved these changes
Oct 16, 2023
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Looks good, tests well, and makes sense! 👍
Thanks 🚀
tyxla
reviewed
Oct 17, 2023
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Something that came up while discussing these kinds of optimizations is that it could be worth adding a comment to describe what we're doing. Otherwise, it could be very easy to lose this optimization in a refactor.
Member
Author
|
@tyxla, can you link this conversation or an issue where I can follow-up on it? I’ve some thoughts as well. |
This was referenced Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A micro-optimization for
customClassNamecontrols to avoid callinguseBlockEditingModefor every block rendered in the editor.Why?
This check is only needed when the control is rendered for the selected block.
How?
Move controls and hook into a new component, which only renders when the feature is supported and block selected.
Testing Instructions
Additional CSS class(es)works as before.Screenshots or screencast