Block Editor: Remove aria-selected from LinkPreview
#43279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
Size Change: +279 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
mirka
reviewed
Aug 17, 2022
| 'is-preview': true, | ||
| 'is-error': isEmptyURL, | ||
| } ) } | ||
| role="option" |
Member
There was a problem hiding this comment.
I'm not exactly sure what's going on in this part of the component, because <LinkPreview> never seems to be contained in a listbox. Could it be the aria-selected part that's unnecessary, perhaps?
Member
Author
There was a problem hiding this comment.
Good call. I've taken a look at the component in action and it doesn't seem to behave as an option in a listbox either.
I've removed the role and the aria-selected as you suggested and fixed the test in c14c0c6.
Feel free to take another look when you get a chance.
tyxla
changed the title
LinkPreviewaria-selected from LinkPreview
mirka
approved these changes
Aug 18, 2022
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Thank you for these follow-ups!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes
aria-selectedfrom theLinkPreviewcomponent as discussed in here and later in this PR.Why?
Using
aria-selectedshould not be used without a role according to the guidelines.How?
We're specifically removing
aria-selectedand reflecting the change in a test.Testing Instructions
Verify all tests still pass.