Block Editor: Refactor LinkControl tests to @testing-library
#43147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
mirka
approved these changes
Aug 15, 2022
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Wow, what a thoroughly tested piece of code 😄 Thanks for working on the big tasks!
I'm not familiar with this component, but the tests do seem to reveal some small a11y things that could be looked at, as you've mentioned as well. Marco and I are not actively maintaining this component, so thanks for picking it up. It's great when we can get tangible user-facing improvements out of refactoring tests!
packages/block-editor/src/components/link-control/test/index.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/link-control/test/index.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/link-control/test/index.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/link-control/test/index.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/link-control/test/index.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/link-control/test/index.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/link-control/test/index.js
Outdated
Show resolved
Hide resolved
tyxla
force-pushed
the
refactor/link-control-rtl
branch
from
d15d14f to
b31e97f
Compare
Co-authored-by: Lena Morita <lena@jaguchi.com>
Co-authored-by: Lena Morita <lena@jaguchi.com>
This was referenced Aug 16, 2022
Member
In case anyone wonders: It's because See also #45777 |
Member
Author
|
Indeed @swissspidy, we did uncover that later and refactored a few of the components from using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR refactors the
<LinkControl />tests to use@testing-libraryinstead ofreact-domand its testing utils.Why?
We've been aiming to have all our component tests resemble user behavior as much as possible, so this is a step in that direction.
How?
This is a complex PR with many different types of changes, namely:
@testing-library/react'srender()instead ofreact-dom's render.@testing-library/user-eventinstead ofreact-dom/test-utilsSimulate.@testing-library/react'sact()instead of thereact-dom/test-utilsone.act()where it is redundant.screenqueries instead ofquerySelectorandquerySelectorAll()toBeTruthy()->toBeVisible()..innerHTML, and morejest-domassertions instead.There's a bug with the
keyDownevents - they simply don't work with@testing-library/user-event, as for some reason the events dispatched there have akeyCode: 0. That's why we're falling back tofireEvent, where we can actually provide thekeyCodeourselves and get around that problem.There are a few more TODOs (and unadressed items from the ones listed above) in the file we're touching, but some of them will likely need changes to the components themselves, and this PR has grown a bit more than I expected, so I'm happy to follow-up with addressing those in another PRs.
Testing Instructions
Verify tests pass:
npm run test:unit packages/block-editor/src/components/link-control/test/index.js