Skip to content

legacy settings menus fixes#1073

Closed
ghost wants to merge 28 commits intomainfrom
unknown repository
Closed

legacy settings menus fixes#1073
ghost wants to merge 28 commits intomainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 22, 2026

No description provided.

@ghost ghost changed the title fixes non op host menu in legacy menu setting fixes non op host menu toggles in legacy menu setting Mar 22, 2026
@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 22, 2026

also fixes the size of the menu
image

@ghost ghost closed this Mar 23, 2026
@github-project-automation github-project-automation Bot moved this from To triage to Done in Legacy4J Issues Tracker Mar 23, 2026
@ghost ghost reopened this Mar 23, 2026
@github-project-automation github-project-automation Bot moved this from Done to Backlog in Legacy4J Issues Tracker Mar 23, 2026
@ghost ghost marked this pull request as draft March 23, 2026 00:21
@ghost ghost changed the title fixes non op host menu toggles in legacy menu setting legacy settings menus fixes Mar 23, 2026
@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 23, 2026

image

fixed graphics menu scaling and pos

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 23, 2026

image game options scaling fixed

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 23, 2026

image

@ghost ghost marked this pull request as ready for review March 23, 2026 02:16
@Cjnator38
Copy link
Copy Markdown
Contributor

oop wrong sensitivity (maybe could change based on if the cursor is visible and is being controlled by the mouse?)

Video_2026-03-22_22-39-05.mp4

@Cjnator38
Copy link
Copy Markdown
Contributor

i wonder if it's possible to make this page shorter only when on the tab 🤔

2026-03-22_23 22 05 image

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 23, 2026

image yep

@ghost ghost marked this pull request as draft March 23, 2026 12:01
@ghost ghost marked this pull request as ready for review March 23, 2026 13:23
@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 23, 2026

fixed the issues reported and the ones ive seen , im now pretty happy with where this features at

@Cjnator38
Copy link
Copy Markdown
Contributor

Cjnator38 commented Mar 23, 2026

one final thing: the root title screen doesn't save the last selected button, so returning to that will always result in Play Game being the selected button. happens on the non-reduced screen as well, and i don't think this happens on stable 1.8.7

Video_2026-03-23_16-02-49.mp4

@ghost ghost marked this pull request as draft March 23, 2026 21:04
@Cjnator38
Copy link
Copy Markdown
Contributor

Cjnator38 commented Mar 23, 2026

backing out of the advanced graphics options when the preset slider is on a different preset than the current should ask for confirmation and apply the preset, like when backing out of the graphics options normally.
(it applies when exiting the normal graphics screen right now, so i thought it was bugged out of pure habit)

also, did you actually implement the warning for when the option is applied through an option preset? dunno if i misread anything so just making sure lol

@Cjnator38
Copy link
Copy Markdown
Contributor

Cjnator38 commented Mar 23, 2026

  • the "biome scale" slider and the sliders included in 1070-compat Legacy-World-Sizes#7 don't match the "world type" and existing size sliders provided by LWS and L4J as of latest commit.
  • line spacing in the tooltip i think is closer than it should be?
  • LWS sliders are flipped, world size should come first
  • currently under the assumption that the loading bar for world creation is not affected by the mock loading bar
2026-03-23_16 46 48 2026-03-23_16 47 00

PlayStation 4 Edition (via Minecraft Wiki):
image

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 23, 2026

maybe the preset slider should just be under gamma?

@Cjnator38
Copy link
Copy Markdown
Contributor

yeah, could be an opt-out thing as well in case someone screams "LEGACY NEVER HAD PRESETS FIX YOUR DUMB MOD"

@Cjnator38
Copy link
Copy Markdown
Contributor

Cjnator38 commented Mar 23, 2026

The mock loading bar foreground could probably be hidden until Loading spawn area is rendered, since the bar seems to show progress prematurely. Ironically, could be more accurate to LCE lol

@ghost ghost closed this by deleting the head repository Mar 24, 2026
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant