Draft
Conversation
Member
MattLish
commented
Mar 19, 2025
MattLish
commented
- refactor: move logger to injected dependency
- refactor: make main directory follow strict typescript settings
- refactor: apply individual eslint rules
- refactor: apply prettier to all files
- fix: restore main file to root for vue electron builder
- chore: sort shared eslint file
- test: use ts-node for tests
- chore: add script to generate mock modpack for testing
- test: add more coverage
- chore: generate more accurate modlist files
- test: ensure all files are shown in coverage
- test: add tests for enb service
- test: ensure sinon is restored
- test: fix async filter test names
- test: add tests for error service
- test: add tests for instruction service
- test: add tests for launcher service
- test: add tests for migration servive
- test: add tests for mod organiser service
- test: add tests modpack service
- test: add tests for profile service
- test: add tests for resolution service
- test: add tests for startup service
- test: add tests for system service
- test: add tests for update service
- test: clean up dirent mock
- test: add tests for wabbajack service
- chore: add docker-compose that runs Windows
- test: add tests for window service
- test: ignore test files from coverage
- test: add tags to main service tests
- test: add playwright with initial test
- test(e2e): add coverage for renderer files
- test: ignore renderer files and controllers in main tests
- test: prevent running e2e tests in parallel
- test: display main process coverage in e2e tests
- test: add missing config test
- test(unit): ignore files that cannot be tested with unit tests
- test(e2e): allow running app while e2e tests run
- test: enable parallel testing
- ci: add e2e tests to ci
MattLish
force-pushed
the
chore/v3.0.0
branch
5 times, most recently
from
56fd68a to
9956679
Compare
… structure - Match renderer, main and preload structure - Use relative renderer paths - Move renderer asserts into renderer directory - Move tools to root resources
- Move images to public directory
…ron main process build - Add preserveModules: true to electron.vite.config.ts rollupOptions - Configure preserveModulesRoot: 'src' for clean output structure - Preserve original directory structure in build output - Maintain individual module files instead of single bundled file - Improve debugging and development experience - All existing functionality and workflows remain compatible
- Migrate .claude directory to .amazonq - Add comprehensive memory bank documentation (guidelines, product, structure, tech) - Add environment, playwright, renderer-testing, and typescript rules - Update .gitignore to exclude .amazonq/plans/completed and archived - Remove .junie configuration - Add BaseButton unit test - Update renderer-components-testing plan with completed BaseButton implementation - Archive test-basebutton plan after completion - Fix mocha spec pattern to only pick up main process tests
- Add tests for option selection with event emission - Add tests for disabled option behavior - Add tests for hidden option filtering - Verify dropdown closes after selection - Verify dropdown stays open when clicking disabled options - Update plan to mark Phase 1.2 complete
- Add user behavior-driven tests for BaseDropdown component - Test dropdown opening/closing via click interactions - Test option selection and event emission - Test keyboard navigation (Enter, Escape, Arrow keys) - Test disabled state behavior - Test placeholder display - Mock Popper component and click-away directive - Follow renderer testing guidelines for user-centric testing
- Add comprehensive test coverage for BaseImage component - Test all props correctly bound to img attributes - Test optional height/width props when not provided - Update test plan to mark phase as complete
- Add comprehensive tests for BaseInput component - Update renderer-components-testing plan to mark BaseButton, BaseImage, and BaseInput as completed - Move completed test plans (test-baseimage, test-baseinput, test-basedropdown) to completed directory - All tests passing (69 renderer tests, 300 main process tests)
- Add AppPage.test.ts with 18 test cases covering all dynamic behavior - Create reusable mock-event-service utility for testing event-driven components - Test route-based navigation visibility, click event management, loading states - Verify event listener registration and cursor state changes - Add new testing guidelines for renderer components, Git MCP, Node MCP, Wallaby, and WebStorm - Update renderer-components-testing plan to mark AppPage as completed - All tests passing with 0 failures (verified with Wallaby)
MattLish
force-pushed
the
chore/v3.0.0
branch
from
83c037f to
add3ee9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.