3.0.0 #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft

MattLish wants to merge 97 commits into main from chore/v3.0.0

.amazonq/.gitignore

-Original file line number
+Diff line change
@@ -0,0 +1,4 @@
+    plans/completed
+    plans/archived
+    playwright-trace

.amazonq/plans/renderer-components-testing.plan.md

-Original file line number
+Diff line change
@@ -0,0 +1,52 @@
+    # Renderer Components Testing Requirements
+    ## All renderer components require comprehensive tests
+    **Note:** Every time a component has a plan to test it, once the testing implementation is completed, this plan should be updated to reflect the completion status.
+    **Important:** After implementing tests for each component, always run the test suite to verify the tests pass before marking the component as completed.
+    ## Component Testing Checklist
+    Below is a complete list of all renderer components that require testing:
+    ### Base Components
+    - [x] AppDropdownFileSelect.vue - completed ✓
+    - [x] AppModal.vue - completed ✓
+    - [x] AppPage.vue - completed ✓
+    - [ ] AppPageContent.vue
+    - [x] BaseButton.vue - completed ✓
+    - [x] BaseDropdown.vue - completed ✓
+    - [x] BaseImage.vue - completed ✓
+    - [x] BaseInput.vue - completed ✓
+    - [ ] BaseLabel.vue
+    - [ ] BaseLink.vue
+    - [ ] BaseList.vue
+    ### Feature Components
+    - [ ] Community.vue
+    - [ ] ENB.vue
+    - [ ] GraphicsSelection.vue
+    - [ ] ImageWithText.vue
+    - [ ] LauncherVersion.vue
+    - [ ] MO2RunningModal.vue
+    - [ ] ModDirectory.vue
+    - [ ] NavigationItem.vue
+    - [ ] News.vue
+    - [ ] Patrons.vue
+    - [ ] ProfileSelection.vue
+    - [ ] Resolution.vue
+    ### Layout Components
+    - [ ] TheHeader.vue
+    - [ ] TheNavigation.vue
+    - [ ] TheTitleBar.vue
+    ## Total Components: 26
+    Each component should have:
+    - Unit tests covering all functionality
+    - Tests should focus on having single assertions per test where possible
+    - Tests should be written in Jest
+    - Child components should always be mocked using shallow mocking by passing shallow:true to the mount function unless the child component is required to be mocked in a specific way.
+    - If a child component is required to be mocked, a comment should be added to the test file explaining why the component is being mocked.

.amazonq/rules/environment.md

-Original file line number
+Diff line change
@@ -0,0 +1,56 @@
+    # Environment Guidelines
+    ## Branch Naming Convention
+    Branches must follow this naming pattern:
+    `{type}/{jira-task-if-available}_{description}`
+    Where:
+    - `type` is one of: `feat`, `fix`, `chore`, `refactor`, `test`
+    - `jira-task-if-available` is the JIRA task ID (if applicable)
+    - `description` is a brief description of the work
+    Examples:
+    - `feat/PROJ-123_add-login-validation`
+    - `fix/PROJ-456_resolve-timeout-issue`
+    - `chore/update-dependencies`
+    - `refactor/PROJ-789_restructure-utils`
+    - `test/PROJ-101_add-integration-tests`
+    ## Git Operations
+    When performing git operations, prioritize the Git MCP server over CLI commands wherever possible.
+    The Git MCP provides better integration and should be used for:
+    - Status checks
+    - Adding files
+    - Committing changes
+    - Branch operations (create AND checkout)
+    - Viewing diffs and logs
+    - Other standard git operations
+    Only fall back to CLI git commands when the MCP doesn't support the required functionality.
+    ### Branch Management
+    When starting work on a new task:
+. **Create the branch** following the naming convention above
+. **Immediately check out the branch** to ensure all work is done on the correct branch
+. Never leave the branch in a created-but-not-checked-out state
+    Use `git_create_branch` to create and `git_checkout` to switch to the branch, or use the appropriate MCP commands that handle both operations.
+    ## Interactive Commands
+    Never use commands that require interactive terminal sessions. This includes:
+    - Commands that prompt for user input
+    - Interactive editors (vim, nano, etc.)
+    - Commands with interactive menus or wizards
+    - Any command that waits for user interaction
+    Always use non-interactive alternatives or provide all required parameters upfront.

.amazonq/rules/git-mcp.md

-Original file line number
+Diff line change
@@ -0,0 +1,53 @@
+    # Git MCP Guidelines
+    ## Git Operations
+    When performing git operations, **always use the Git MCP server** instead of CLI commands.
+    The Git MCP provides better integration and should be used for all git operations including:
+    - Status checks (`git_status`)
+    - Adding files (`git_add`)
+    - Committing changes (`git_commit`)
+    - Branch operations (`git_create_branch`, `git_checkout`)
+    - Viewing diffs (`git_diff`, `git_diff_staged`, `git_diff_unstaged`)
+    - Viewing logs (`git_log`)
+    - Showing commits (`git_show`)
+    - Resetting staged changes (`git_reset`)
+    - Repository initialization (`git_init`)
+    ### Available Git MCP Tools
+    - `git_status` - Show working tree status
+    - `git_add` - Add files to staging area
+    - `git_commit` - Record changes to repository
+    - `git_create_branch` - Create new branch
+    - `git_checkout` - Switch branches
+    - `git_diff` - Show differences between branches/commits
+    - `git_diff_staged` - Show staged changes
+    - `git_diff_unstaged` - Show unstaged changes
+    - `git_log` - Show commit logs
+    - `git_show` - Show commit contents
+    - `git_reset` - Unstage all staged changes
+    - `git_init` - Initialize new repository
+    ### Best Practices
+. **Always use Git MCP tools** instead of `executeBash` with git commands
+. **Never fall back to CLI** - all standard git operations are supported
+. Follow branch naming conventions as specified in environment.md
+. Create and immediately checkout new branches
+    ### Examples
+    ```typescript
+    // ✅ Good: Use Git MCP
+    git_status({ repo_path: "/path/to/repo" })
+    git_add({ repo_path: "/path/to/repo", files: ["file.ts"] })
+    git_commit({ repo_path: "/path/to/repo", message: "feat: add feature" })
+    // ❌ Bad: Use bash
+    executeBash({ command: "git status", cwd: "/path/to/repo" })
+    executeBash({ command: "git add file.ts", cwd: "/path/to/repo" })
+    executeBash({ command: "git commit -m 'feat: add feature'", cwd: "/path/to/repo" })
+    ```

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

3.0.0 #721

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

3.0.0 #721

Are you sure you want to change the base?

Uh oh!

3.0.0 #721

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!