Skip to content

fix build issue #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Saurabh186 merged 1 commit into from
Mar 30, 2026
Merged

fix build issue #505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
with:
useRollingCache: true
working-directory: .
install-command: npm ci --audit false
install-command: npm ci --audit false --legacy-peer-deps
Copy link
Copy Markdown

@windsurf-bot windsurf-bot bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While adding --legacy-peer-deps might fix the immediate build issue, it's generally considered a workaround rather than a proper fix. This flag bypasses npm's peer dependency validation, which could mask underlying dependency conflicts.

Consider:

  1. Documenting why this flag is needed
  2. Creating a follow-up task to properly resolve the dependency conflicts
  3. Specifying which package(s) are causing the peer dependency issues


- name: Starting build check
shell: bash
Expand Down
Loading