Skip to content

fix build issue#505

Merged
Saurabh186 merged 1 commit intodevelopmentfrom
P0080-clean
Mar 30, 2026
Merged

fix build issue#505
Saurabh186 merged 1 commit intodevelopmentfrom
P0080-clean

Conversation

@Saurabh186
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 To request another review, post a new comment with "/windsurf-review".

useRollingCache: true
working-directory: .
install-command: npm ci --audit false
install-command: npm ci --audit false --legacy-peer-deps
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While adding --legacy-peer-deps might fix the immediate build issue, it's generally considered a workaround rather than a proper fix. This flag bypasses npm's peer dependency validation, which could mask underlying dependency conflicts.

Consider:

  1. Documenting why this flag is needed
  2. Creating a follow-up task to properly resolve the dependency conflicts
  3. Specifying which package(s) are causing the peer dependency issues

@Saurabh186 Saurabh186 merged commit 1ad582e into development Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants