vmagent: support both endpointslice and endpointslices roles

[AndrewChubatiuk]

in 0.67.0 updated endpointslices role value to endpointslice relying on official documentation
restoring old value and added warning to help with migration

---

Summary by cubic

Restores compatibility by supporting both "endpointslice" and legacy "endpointslices" for VMServiceScrape discoveryRole. Existing configs keep working; using "endpointslices" logs a deprecation warning.

• Bug Fixes
  • CRD validation now accepts both values.
  • vmagent config generation treats both roles the same for relabeling, metadata, and watchers.
  • Webhook logs a warning when "endpointslices" is used; changelog updated.

^{Written for commit c9674a5. Summary will update on new commits.}

[cubic-dev-ai]

2 issues found across 6 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:29">
P1: Rule violated: **Changelog Review Agent**

Changelog entry violates the required structure: it doesn’t explain the before/now user-visible behavior and omits mandatory issue/PR references (see Changelog Review Agent ‘Required structure’ items 3 and 4).</violation>
</file>

<file name="internal/controller/operator/factory/vmagent/servicescrape.go">

<violation number="1" location="internal/controller/operator/factory/vmagent/servicescrape.go:90">
P2: `k8sSDRoleLegacyEndpointslices` is only handled in the port-filter switch, but not in the later relabeling switch, so legacy role targets skip endpointslice-specific relabelings (pod/container/node labels). If legacy is intended to behave like endpointslice, it should be included in that later switch as well.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P1: Rule violated: Changelog Review Agent

Changelog entry violates the required structure: it doesn’t explain the before/now user-visible behavior and omits mandatory issue/PR references (see Changelog Review Agent ‘Required structure’ items 3 and 4).

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At docs/CHANGELOG.md, line 29:

<comment>Changelog entry violates the required structure: it doesn’t explain the before/now user-visible behavior and omits mandatory issue/PR references (see Changelog Review Agent ‘Required structure’ items 3 and 4).</comment>

<file context>
@@ -26,6 +26,7 @@ aliases:
 * BUGFIX: [vmoperator](https://docs.victoriametrics.com/operator/): fixed conflicts for `VMAlert`, `VMAlertmanager` and `VMAuth` reconcilers, which are updating same objects concurrently with reconcilers for their child objects.
 * BUGFIX: [vmoperator](https://docs.victoriametrics.com/operator/): previously PVC downscaling always emitted a warning, which is not expected, while using PVC autoresizer; now warning during attempt to downsize PVC is only emitted if `operator.victoriametrics.com/pvc-allow-volume-expansion: false` is not set. See [#1747](https://github.com/VictoriaMetrics/operator/issues/1747).
 * BUGFIX: [vmoperator](https://docs.victoriametrics.com/operator/): skip self scrape objects management if respective controller is disabled. See [#1718](https://github.com/VictoriaMetrics/operator/issues/1718).
+* BUGFIX: [vmagent](https://docs.victoriametrics.com/operator/resources/vmagent/): support both prometheus-compatible `endpointslice` and old `endpointslices` roles.
 
 ## [v0.67.0](https://github.com/VictoriaMetrics/operator/releases/tag/v0.67.0)
</file context>

[christensenjairus]

@AndrewChubatiuk Thanks for finding this. Changing discoveryRole: endpointslices to discoveryRole: endpointslice fixed my issue 👍