chore: decouple scraping logic from vmagent code

[AndrewChubatiuk]

decoupling scrape configuration functions from vmagent to be able to reuse it later by vmsingle
preparation for #1702

[Copilot]

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[christensenjairus]

@AndrewChubatiuk @vrutkovs Are we sure we haven't broken functionality here? This is the only commit between the two most recent versions that looks to be related to an issue I'm seeing.

W/ the new version (0.67.0) if I have multiple scrapes defined for the same endpointslices, vmagent gets the definitions of all of them jumbled.

Here's an example:

v0.66.1 (working as intended)

v0.67.0

It gets the ports, protocols, everything confused, and even duplicated, as if it's trying to scrape every port it knows exists

[AndrewChubatiuk]

this PR is not included into 0.67.0, I'll check changes that happened before
could you please share these service scrape objects and vmagent CR?

[vrutkovs]

Please file a new bug for this, as Andrew has pointed out this PR didn't make it in 0.67

[AndrewChubatiuk]

looked through diff 0.66.1...0.67.0 and found one change, that could lead to this issue, created PR with a fix