Conversation
Signed-off-by: Bassem Mohsen <bassem.nomany@gmail.com>
Signed-off-by: Bassem Mohsen <bassem.nomany@gmail.com>
Signed-off-by: Bassem Mohsen <bassem.nomany@gmail.com>
Controller page progressbar
Misc UI improvement
Fixed an issue where clicking on a control within SettingsCard (when IsClickable) would trigger the SettingsCard click.
Fix MainWindow Glyph ForegroundProperty
Endurance gaming
The bigger the interval, the lower the CPU usage.
- DualSense - DualShock4 - Nintendo Switch Pro - MSI Claw (DInput)
Fix Enum following our transition to SDL for a few controllers
* (Tentative) Fix TDP/Fan issues * Misc: migrate powerProfile management to IDevice * update lib
* Improved: Controller management * Improved: Per-device hotkeys
* Improved: HC won't wait until session is ready anymore, except for keyboard input management * Fixed: Device management asynchronous refresh * Fixed: Device management asynchronous refresh * oups * Revert "Fixed: Profile update when resolution or refresh rate is changed" This reverts commit 0fa4512. * only update if necessary
…anion.sys to defender exclusion list
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughBroad refactor introduces delta-aware input execution, restructures input states (buttons/axes/gyro) to array-backed storage, replaces PlatformType with flags-based GamePlatform and adds EA Desktop. Adds device default hotkeys, new XboxAdaptiveController, extensive manager updates (layouts, hotkeys, lighting, motion), new ButtonCommands, utilities, project/package updates, installer/version bump, and localization changes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Controller as Controller (tick)
participant LayoutMgr as LayoutManager
participant Actions as Actions (IActions & derived)
participant Outputs as Outputs
Note over Controller,Outputs: Per-frame input processing with delta
User->>Controller: Physical input
Controller->>LayoutMgr: Tick(state, delta)
LayoutMgr->>Actions: Execute(..., delta) per binding
alt Axis/Button/Mouse/Keyboard/Trigger
Actions-->>Actions: Update outVector/outBool, timers
end
Actions->>Outputs: Emit mapped state
Outputs-->>User: Resulting behavior
sequenceDiagram
autonumber
participant App as App Startup
participant Device as IDevice.GetCurrent()
participant Hotkeys as HotkeysManager
participant Storage as JSON Profiles
Note over App,Hotkeys: First-run hotkey deployment
App->>Hotkeys: Start()
Hotkeys->>Device: Read DeviceHotkeys
Hotkeys->>Storage: Load existing hotkeys
Hotkeys-->>Hotkeys: Skip duplicates/conflicts
Hotkeys->>Storage: Persist created hotkeys
sequenceDiagram
autonumber
participant OS as Device Arrival/Suspend/Resume
participant CtrlMgr as ControllerManager
participant XAC as XboxAdaptiveController
Note over CtrlMgr,XAC: ASUS Xbox Adaptive handling
OS->>CtrlMgr: USB arrival (VID 0x0B05, PID 0x1B4C)
CtrlMgr->>XAC: Instantiate/Attach
OS->>CtrlMgr: Suspend request
CtrlMgr->>XAC: Disable()
OS->>CtrlMgr: Resume request
CtrlMgr->>XAC: Enable()
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120+ minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (13)
📒 Files selected for processing (107)
⛔ Files not processed due to max files limit (21)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit