Conversation
…robust device manager arrival logic
We should move the PlatformToProfile logic to LibraryManager or PlatformManager
… and SettingsCard
…) to compute velocity memory
…get.GetDefault() is called
* WIP * More work * build 0.28.3.2
…interval for start delay) (#484) Signed-off-by: Pedro Parra Ortega <parraortega.pedro@gmail.com>
* feat: improve layout system * fix: correct inherit and added missing configurations
* temp tests * more work * more work * more work * more work * more work * misc * More work * fix * more work * more work * Misc * Improved SteamGridDb, will now capture official artworks first * Misc UI tweaks * Misc fixes * more work * more work * Misc UI * Misc UI tweaks * code cleanup * build 0.28.3.3
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe application version is updated from 0.28.3.1 to 0.28.3.3. Changes introduce shift matching flexibility (strict vs OR-based modes), expand controller slot management to support automatic/manual issue detection and remediation, add mouse MoveTo cursor positioning, refactor action execution logic with pattern matching, create new action settings UI infrastructure, update terminology from "emulated" to "virtual controller" across localization, and update package dependencies. Settings keys MainWindowIsPaneOpen and ControllerManagement are replaced with ControllerSlotManagementMode and MasterInterval. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ControllerMgr as ControllerManager
participant Monitor as SlotMonitor
participant UI as ToastManager
participant Fix as SlotFixWatchdog
participant State as ControllerState
Note over Monitor,Fix: Automatic Slot Management Flow
Monitor->>Monitor: SlotMonitorLoop checks slots periodically
Monitor->>State: Detects issue (occupancy/config problem)
State->>ControllerMgr: Updates HasSlotIssue & SlotIssueReason
ControllerMgr->>ControllerMgr: Raises SlotIssueChanged event
ControllerMgr->>UI: ShowDetectedToast (if not debounced)
alt Manual Mode
UI-->>User: Prompt: Fix or Ignore?
User->>UI: Click Fix
UI->>ControllerMgr: TriggerSlotFix(resetAttempts: true)
else Automatic Mode
ControllerMgr->>Fix: Auto-start WatchdogLoop
end
Fix->>State: Probe & attempt remediation
Fix->>Monitor: Re-check slot state
Monitor->>State: Verify fix success
State->>ControllerMgr: Update HasSlotIssue
ControllerMgr->>UI: TrySendSlotFixStatusToast (Success/Failed)
UI-->>User: Notify result
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes The PR spans significant logic changes in controller management (slot detection/fix loops), extensive ViewModel refactoring with new virtual properties and overrides, new action settings UI infrastructure, and widespread localization updates. While localization changes are repetitive, the heterogeneous nature of feature additions (slot management, shift matching, MoveTo, UI overhaul) and logic density in managers and ViewModels demand careful per-area reasoning. Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Chores