Update ksrates to version 2.0.0#63
Merged
Cecilia-Sensalari merged 73 commits intomasterfrom May 21, 2025
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 76 out of 82 changed files in this pull request and generated no comments.
Files not reviewed (6)
- Dockerfile: Language not supported
- Singularity: Language not supported
- docs/concept.rst: Language not supported
- docs/configuration.rst: Language not supported
- docs/index.rst: Language not supported
- docs/input_output.rst: Language not supported
Comments suppressed due to low confidence (2)
docs/conf.py:4
- Ensure that the updated relative path correctly locates 'ksrates/_version.py' given the project structure; if the module location has also changed, update the accompanying comment accordingly.
p = os.path.abspath('..')
.github/workflows/test_pipeline.yml:40
- [nitpick] Confirm that the addition of the '--test' flag along with the new configuration file paths is intentional and aligns with the expected testing workflow to avoid unintended behavior in production runs.
NXF_VER=23.10.1 nextflow run ../main.nf --test --config config_files/config_elaeis.txt --expert config_files/config_expert.txt -with-docker ksrates
There was a problem hiding this comment.
Copilot reviewed 76 out of 82 changed files in this pull request and generated no comments.
Files not reviewed (6)
- Dockerfile: Language not supported
- Singularity: Language not supported
- docs/concept.rst: Language not supported
- docs/configuration.rst: Language not supported
- docs/index.rst: Language not supported
- docs/input_output.rst: Language not supported
Comments suppressed due to low confidence (3)
docs/conf.py:4
- The change from '../..' to '..' may cause an incorrect import of ksrates._version if the version file is still located two directories up. Please verify that the updated path matches the actual project structure.
p = os.path.abspath('..')
docs/conf.py:3
- There is a mismatch between the comment indicating a two-level up import path and the updated one-level up path in the code; consider updating the comment or the path to maintain consistency.
# Import version following relative path ../../ksrates/ksrates/_version.py
.github/workflows/test_pipeline.yml:40
- The addition of the '--test' flag alters the command behavior; please confirm that running Nextflow in test mode is intentional for the CI pipeline.
NXF_VER=23.10.1 nextflow run ../main.nf --test --config config_files/config_elaeis.txt --expert config_files/config_expert.txt -with-docker ksrates
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR integrating code for version 2.0.0
Major updates:
Minor updates:
linux/amd64platform and no longer forlinux/arm64requirements.txtorthologs_ks_cleanup: deletes all ortholog BLAST tables fromortholog_distributionsdirectory to free disk space; to be executed manuallyparalogs_ks_multi: executes the paralog Ks estimation for all species present in the Newick tree instead than for only the focal species; to be executed manuallyprofilesto set up containerstest/rate_adjustment/elaeisdirectory) to allow inspection of error logs and output files