Supporting new Nextflow DSL2 syntax#51
Closed
Cecilia-Sensalari wants to merge 3 commits intomasterfrom
Closed
Conversation
Closed
Collaborator
Author
|
This got implemented in PR #63. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the Nextflow pipeline file (
main.nf) inksratescompatible with the recent Nextflow DSL2 syntax, which has replaced the older DSL1 since version22.03.0-edge.Based on my experience, current Nextflow versions (e.g.
23.04.1) do not support DSL1 anymore, even when specifically setting it from command line (-dsl1) or in the configuration file.With the changes in this PR, the Nextflow pipeline has been successfully executed on the
testdataset, but further testing is required to make sure that all building blocks of the pipeline ('processes') are still correctly wired.Notes concerning the migration to DSL2 syntax: this mainly involves defining an extra block of code called
workflowwhere processes are called; process input and output are provided/retrieved directly in this block. Therefore, allfromandintoconnections within process definition blocks are removed.Other related changes: YML file (
.github/workflows/test_pipeline.yml) for CI in GitHub also updated by not asking Nextflow to run an older version compatible with DSL1.TODO: