Skip to content

feat: Add abfload3 to read DAC command waveforms from ABF files #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: Add abfload3 to read DAC command waveforms from ABF files #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion +ndr/+format/+axon/read_abf.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
case {'ai','analog_in'},
channel_names = header.recChNames(channel_numbers);
[channel_num_sorted,channel_num_sorted_idx] = sort(channel_numbers);
data = abfload2(filename,'start',t0,'stop',t1+1e-6*header.si,'channels',channel_names,...
data = abfload3(filename,'start',t0,'stop',t1+1e-6*header.si,'channels',channel_names,...
'doDispInfo',false);
if size(data,3)>1, % sweeps are different, it seems to read in the whole thing and ignore the times
times = ndr.format.axon.read_abf(filename, header, 'time', 1, -inf, inf);
Expand Down
2 changes: 1 addition & 1 deletion +ndr/+format/+axon/read_abf_header.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
% Relies on abfload from https://github.com/fcollman/abfload
%

[d,si,h]=abfload2(filename,'start',0,'stop',0.1,'doDispInfo',false);
[d,si,h]=abfload3(filename,'start',0,'stop',0.1,'doDispInfo',false);

Check warning

Code scanning / Code Analyzer

Value assigned to variable might be unused. Consider replacing the variable with ~ instead. Warning

Value assigned to variable might be unused. Consider replacing the variable with ~ instead.

Check warning

Code scanning / Code Analyzer

Value assigned to variable might be unused. Consider replacing the variable with ~ instead. Warning

Value assigned to variable might be unused. Consider replacing the variable with ~ instead.

Loading