feat: Add abfload3 to read DAC command waveforms from ABF files#73
feat: Add abfload3 to read DAC command waveforms from ABF files#73google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
This commit introduces `abfload3`, a new function based on `abfload2`, to read additional data types from Axon Instruments ABF files. The new function is inspired by the capabilities of the `swharden/pyABF` Python library and is specifically designed to extract DAC command waveforms, which were not previously supported. The key changes include: - Creation of `abfload3.m` with added logic to read DAC command waveforms from ABF version 2 files and append them as new analog channels. - Updates to `+ndr/+format/+axon/read_abf.m` and `+ndr/+format/+axon/read_abf_header.m` to use the new `abfload3` function.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| % | ||
|
|
||
| [d,si,h]=abfload2(filename,'start',0,'stop',0.1,'doDispInfo',false); | ||
| [d,si,h]=abfload3(filename,'start',0,'stop',0.1,'doDispInfo',false); |
Check warning
Code scanning / Code Analyzer
Value assigned to variable might be unused. Consider replacing the variable with ~ instead. Warning
| % | ||
|
|
||
| [d,si,h]=abfload2(filename,'start',0,'stop',0.1,'doDispInfo',false); | ||
| [d,si,h]=abfload3(filename,'start',0,'stop',0.1,'doDispInfo',false); |
Check warning
Code scanning / Code Analyzer
Value assigned to variable might be unused. Consider replacing the variable with ~ instead. Warning
Test Results32 tests 32 ✅ 1s ⏱️ Results for commit 7e7b057. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 14.34% 14.34%
=======================================
Files 82 82
Lines 3402 3402
=======================================
Hits 488 488
Misses 2914 2914 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This change introduces
abfload3, a new function based onabfload2, to read additional data types from Axon Instruments ABF files. The new function is inspired by the capabilities of theswharden/pyABFPython library and is specifically designed to extract DAC command waveforms, which were not previously supported.The key changes include:
abfload3.mwith added logic to read DAC command waveforms from ABF version 2 files and append them as new analog channels.+ndr/+format/+axon/read_abf.mand+ndr/+format/+axon/read_abf_header.mto use the newabfload3function.PR created automatically by Jules for task 14806485424088288401