Skip to content

Anandsound#36

Merged
marceloams merged 7 commits intoUselessCo:developfrom
anacodermisra:anandsound
Oct 23, 2025
Merged

Anandsound#36
marceloams merged 7 commits intoUselessCo:developfrom
anacodermisra:anandsound

Conversation

@anacodermisra
Copy link
Contributor

@anacodermisra anacodermisra commented Oct 17, 2025

Pull Request

Type of Change

  • Bug fix
  • New feature
  • Sound contribution
  • Configuration contribution
  • Documentation update
  • Other (specify)

Description

Added Bird sound

Related Issue

Closes #(2)

Changes Made

  • Change 1 Added dog barking sound mp3 file
  • Change 2 Listed the file in readme.md
  • Change 3

For Sound Contributions

  • Sound is in MP3 format
  • File size is under 500KB
  • Added sound to assets/sounds/
  • Created/updated config that uses the sound

For Code Changes

  • Code follows project style
  • No console.log in production code
  • All imports have .js extensions
  • Tested locally
  • Updated documentation if needed

Screenshots/Audio

If applicable, add screenshots or audio samples (Optional: SoundCloud, YouTube, etc.).

Checklist

  • My code/contribution follows the project guidelines
  • I have tested my changes
  • I have updated documentation as needed
  • My changes don't break existing functionality

@anacodermisra
Copy link
Contributor Author

Hey the bird sound was exceeding the size limit so added a different sound
Kindly check

@marceloams
Copy link
Contributor

Hey @anacodermisra! Sound size is perfect, thanks! Just please remove the assets/sounds/README.md changes, no need to update it when adding sounds. Since you already have a config PR open, just revert the README changes and you're good! 🚀

@anacodermisra
Copy link
Contributor Author

Sir please check

@marceloams
Copy link
Contributor

Hey @anacodermisra! You still have extra changes though, please revert those and keep only the sound file. Only the sound is needed here. Thanks!

@marceloams marceloams mentioned this pull request Oct 21, 2025
19 tasks
@anacodermisra
Copy link
Contributor Author

Sorry for multiple commits.
Kindly check if now there aren't any extra changes.
Thankyou

@marceloams
Copy link
Contributor

marceloams commented Oct 21, 2025

@anacodermisra Try running npm run format and push a new commit. That should remove the remaining README changes automatically!

@anacodermisra
Copy link
Contributor Author

@marceloams Thankyou!
Kindly check now

@marceloams marceloams merged commit acb64ae into UselessCo:develop Oct 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants