Skip to content

Add your-config-name config#37

Merged
marceloams merged 3 commits intoUselessCo:developfrom
anacodermisra:add-config-barkingconfig
Oct 23, 2025
Merged

Add your-config-name config#37
marceloams merged 3 commits intoUselessCo:developfrom
anacodermisra:add-config-barkingconfig

Conversation

@anacodermisra
Copy link
Contributor

@anacodermisra anacodermisra commented Oct 17, 2025

Pull Request

Type of Change

  • Bug fix
  • New feature
  • Sound contribution
  • Configuration contribution
  • Documentation update
  • Other (specify)

Description

Brief description of the changes.
Added configuration for barking dog

Related Issue

Closes #(3)

Changes Made

  • Change 1
  • Change 2
  • Change 3

For Sound Contributions

  • Sound is in MP3 format
  • File size is under 500KB
  • Added sound to assets/sounds/
  • Created/updated config that uses the sound

For Code Changes

  • Code follows project style
  • No console.log in production code
  • All imports have .js extensions
  • Tested locally
  • Updated documentation if needed

Screenshots/Audio

If applicable, add screenshots or audio samples (Optional: SoundCloud, YouTube, etc.).

Checklist

  • My code/contribution follows the project guidelines
  • I have tested my changes
  • I have updated documentation as needed
  • My changes don't break existing functionality

@marceloams
Copy link
Contributor

Hey @anacodermisra! There's a formatting error, please run npm run format to fix it and push a new commit. Thanks!

@anacodermisra
Copy link
Contributor Author

Pls check if it is working, i ran the format command and installed prettier

@marceloams
Copy link
Contributor

Hey @anacodermisra! Thanks for formatting the code, that's great! Just one thing, we don't need the package-lock.json and package.json changes (prettier version update) in this PR. Could you please revert those changes and keep just your config?

@anacodermisra
Copy link
Contributor Author

Please check I have reverted the changes. Thankyou

@marceloams
Copy link
Contributor

@anacodermisra Looks good! I'll merge this once PR #36 (the sound addition) is updated. Thanks!

@marceloams marceloams merged commit 6eda0c9 into UselessCo:develop Oct 23, 2025
11 checks passed
@marceloams
Copy link
Contributor

@anacodermisra Thanks for your contribution!! 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants