Skip to content

fix: remove incorrect trajectory_grid vs instrumentation warning #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jon-myers merged 1 commit into from
Dec 10, 2025
Merged

fix: remove incorrect trajectory_grid vs instrumentation warning #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions idtap/classes/phrase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,31 +292,6 @@ def _validate_parameter_values(self, opts: Dict[str, Any]) -> None:
if len(dur_array) > 0 and sum(dur_array) == 0:
raise ValueError("'dur_array' cannot have all zero values")

# Validate grid structure consistency
if 'trajectory_grid' in opts and 'instrumentation' in opts:
trajectory_grid = opts['trajectory_grid']
instrumentation = opts['instrumentation']
if len(trajectory_grid) != len(instrumentation):
import warnings
warnings.warn(f"trajectory_grid has {len(trajectory_grid)} tracks but instrumentation has {len(instrumentation)} instruments. "
"These should typically match.", UserWarning)

if 'chikari_grid' in opts and 'instrumentation' in opts:
chikari_grid = opts['chikari_grid']
instrumentation = opts['instrumentation']
if len(chikari_grid) != len(instrumentation):
import warnings
warnings.warn(f"chikari_grid has {len(chikari_grid)} tracks but instrumentation has {len(instrumentation)} instruments. "
"These should typically match.", UserWarning)

if 'groups_grid' in opts and 'instrumentation' in opts:
groups_grid = opts['groups_grid']
instrumentation = opts['instrumentation']
if len(groups_grid) != len(instrumentation):
import warnings
warnings.warn(f"groups_grid has {len(groups_grid)} tracks but instrumentation has {len(instrumentation)} instruments. "
"These should typically match.", UserWarning)

# Validate categorization grid structure
if 'categorization_grid' in opts and opts['categorization_grid'] is not None:
for i, cat in enumerate(opts['categorization_grid']):
Expand Down
Loading