fix: remove incorrect trajectory_grid vs instrumentation warning #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Phrase class was incorrectly warning when trajectory_grid, chikari_grid, and groups_grid dimensions didn't match instrumentation length. This validation is architecturally wrong - instrumentation relates to phrase_grid dimensions at the Piece level, not at the Phrase level. As of recent updates, trajectory_grid will have 2 dimensions for both Sitar and Sarangi instruments, independent of piece-level instrumentation. Closes #49 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
📦 Test Package Built Successfully! This PR has been automatically built and uploaded to TestPyPI for testing. 🔗 TestPyPI Link: https://test.pypi.org/project/idtap/ To test this version: pip install --index-url https://test.pypi.org/simple/ idtap✅ All tests passed and package builds successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
trajectory_grid,chikari_grid, andgroups_griddimensions againstinstrumentationlengthinstrumentationrelates tophrase_griddimensions at the Piece level, not at the Phrase leveltrajectory_gridwill have 2 dimensions for both Sitar and Sarangi instruments, independent of piece-level instrumentationChanges
idtap/classes/phrase.py(lines 295-318)piece.py:426-429forphraseGridvsinstrumentationTest plan
Closes #49
🤖 Generated with Claude Code