-
Notifications
You must be signed in to change notification settings - Fork 2
Fix readme #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pro
wants to merge
3
commits into
TwilightCoders:master
Choose a base branch
from
Pro:fix_readme
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix readme #2
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,11 +9,19 @@ Explore the tree and most of the modifications you may want to make should be fa | |
|
|
||
| Check out this repository: | ||
|
|
||
| `git clone git@github.com:TwilightCoders/iocage-plugin-fail2ban.git` | ||
| `git clone https://github.com/TwilightCoders/iocage-plugin-fail2ban.git` | ||
|
|
||
| Install with `iocage` from within the project directory: | ||
| - `iocage fetch -P -n fail2ban.json ip4_addr="[interface]|[ip_address]/[cidr]"` | ||
| - e.g. `iocage fetch -P -n fail2ban.json ip4_addr="em0|192.168.0.111/24"` | ||
| Install with `iocage` from within the project directory. | ||
|
|
||
| You can either use NAT (recommended for FreeNAS >= 11.3): | ||
|
|
||
| - `iocage fetch -P fail2ban.json vnet=1 nat=1` | ||
|
|
||
| Or a specific IP: | ||
|
|
||
| - `iocage fetch -P fail2ban.json ip4_addr="[interface]|[ip_address]/[cidr]"` | ||
|
|
||
| - e.g. `iocage fetch -P fail2ban.json ip4_addr="em0|192.168.0.111/24"` | ||
|
Comment on lines
+14
to
+24
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Awesome, I like this better. |
||
|
|
||
| ## Configuration | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "Fail2Ban", | ||
| "release": "11.2-RELEASE", | ||
| "name": "fail2ban", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep, good call. 👌🏼 |
||
| "release": "11.3-RELEASE", | ||
| "artifact": ".", | ||
| "pkgs": [ | ||
| "python36", | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to encourage
sshoverhttpsas a standard amongst these projects.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that one needs to have an ssh key setup for Github to access the ssh url.
Only https works for anonymous...
https://stackoverflow.com/a/46993922/869402
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know, that's a really good point! I never considered that, and I appreciate the perspective. I'm going to modify the other
iocageplugins I'm creating for the same reason. Thanks!