Skip to content

Fix readme#2

Open
Pro wants to merge 3 commits intoTwilightCoders:masterfrom
Pro:fix_readme
Open

Fix readme#2
Pro wants to merge 3 commits intoTwilightCoders:masterfrom
Pro:fix_readme

Conversation

@Pro
Copy link
Copy Markdown

@Pro Pro commented Apr 18, 2020

No description provided.

Copy link
Copy Markdown
Member

@voltechs voltechs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Pro,

Thanks for opening a PR for this! (Been on my mind to ask the community for comments/review).

Most of this looks great. I have one requested change regarding ssh vs https.

Check out this repository:

`git clone git@github.com:TwilightCoders/iocage-plugin-fail2ban.git`
`git clone https://github.com/TwilightCoders/iocage-plugin-fail2ban.git`
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to encourage ssh over https as a standard amongst these projects.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that one needs to have an ssh key setup for Github to access the ssh url.
Only https works for anonymous...

https://stackoverflow.com/a/46993922/869402

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, that's a really good point! I never considered that, and I appreciate the perspective. I'm going to modify the other iocage plugins I'm creating for the same reason. Thanks!

Comment on lines +14 to +24
Install with `iocage` from within the project directory.

You can either use NAT (recommended for FreeNAS >= 11.3):

- `iocage fetch -P fail2ban.json vnet=1 nat=1`

Or a specific IP:

- `iocage fetch -P fail2ban.json ip4_addr="[interface]|[ip_address]/[cidr]"`

- e.g. `iocage fetch -P fail2ban.json ip4_addr="em0|192.168.0.111/24"`
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I like this better.

{
"name": "Fail2Ban",
"release": "11.2-RELEASE",
"name": "fail2ban",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good call. 👌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants