Skip to content

Testing PR where to find CI #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TsuyoshiUshio wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Testing PR where to find CI #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6047d8c
Bad password
TsuyoshiUshio Jun 16, 2019
31a3cf8
Update README.md
TsuyoshiUshio Jun 16, 2019
663e8f2
Update README.md
TsuyoshiUshio Jun 16, 2019
396079f
Update README.md
TsuyoshiUshio Jun 16, 2019
e944bf6
Update README.md
TsuyoshiUshio Jun 16, 2019
9bf4899
Update README.md
TsuyoshiUshio Jun 17, 2019
2d5d418
Update README.md
TsuyoshiUshio Jun 17, 2019
9e61bb1
Update HomeController.cs
TsuyoshiUshio Jun 17, 2019
29b147d
Update README.md
TsuyoshiUshio Jun 17, 2019
acaa2f4
Update README.md
TsuyoshiUshio Jul 29, 2019
ef3efc6
Update very secure information
TsuyoshiUshio Jul 29, 2019
f8f3fb2
Update README.md
TsuyoshiUshio Jul 29, 2019
ff4d5e7
Update README.md
TsuyoshiUshio Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,4 @@ Get the IP address of the docker container

access the IP address with your browser. then you can see the website.



someone
3 changes: 3 additions & 0 deletions VulnerableApplication/Controllers/HomeController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,8 @@ public ActionResult Contact()
public string Hello() {
return "this is not on the coding rules.";
}

private static string ChangePassword = "PassWord917231";
Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE_SMELL

4 more lines of code need to be covered by tests to reach the minimum threshold of 65.0% lines coverage.
See details

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/falsepositive

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue marked as falsepositive. For more detail.

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE_SMELL

10 more comment lines need to be written to reach the minimum threshold of 25.0% comment density.
See details

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/workitem

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WorkItem 906 Created see workItem.

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE_SMELL

Add or update the header of this file.
See details

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/falsepositive

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue marked as falsepositive. For more detail.

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE_SMELL

Remove the unused private field 'ChangePassword'.
See details

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/workitem

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WorkItem 907 Created see workItem.

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VULNERABILITY

'password' detected in this expression, review this potentially hardcoded credential.
See details

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE_SMELL

The field 'HomeController.ChangePassword' is assigned but its value is never used
See details

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE_SMELL

Remove this method and declare a constant for this value.
See details


}
}