Testing PR where to find CI by TsuyoshiUshio · Pull Request #17 · TsuyoshiUshio/VulnerableApp

TsuyoshiUshio · 2019-07-29T21:26:48Z

This is the sample of the Security Bot Pull Request Validation

TsuyoshiUshio · 2019-07-29T22:03:38Z

VulnerableApplication/Controllers/HomeController.cs

        return "this is not on the coding rules.";
        }
+
+        private static string ChangePassword = "PassWord917231";


CODE_SMELL

4 more lines of code need to be covered by tests to reach the minimum threshold of 65.0% lines coverage.
See details

/falsepositive

The issue marked as falsepositive. For more detail.

TsuyoshiUshio · 2019-07-29T22:03:39Z

VulnerableApplication/Controllers/HomeController.cs

        return "this is not on the coding rules.";
        }
+
+        private static string ChangePassword = "PassWord917231";


CODE_SMELL

10 more comment lines need to be written to reach the minimum threshold of 25.0% comment density.
See details

WorkItem 906 Created see workItem.

TsuyoshiUshio · 2019-07-29T22:03:40Z

VulnerableApplication/Controllers/HomeController.cs

        return "this is not on the coding rules.";
        }
+
+        private static string ChangePassword = "PassWord917231";


CODE_SMELL

Add or update the header of this file.
See details

/falsepositive

The issue marked as falsepositive. For more detail.

TsuyoshiUshio · 2019-07-29T22:03:41Z

VulnerableApplication/Controllers/HomeController.cs

        return "this is not on the coding rules.";
        }
+
+        private static string ChangePassword = "PassWord917231";


CODE_SMELL

Remove the unused private field 'ChangePassword'.
See details

WorkItem 907 Created see workItem.

TsuyoshiUshio · 2019-07-29T22:03:41Z

VulnerableApplication/Controllers/HomeController.cs

        return "this is not on the coding rules.";
        }
+
+        private static string ChangePassword = "PassWord917231";


VULNERABILITY

'password' detected in this expression, review this potentially hardcoded credential.
See details

TsuyoshiUshio · 2019-07-29T22:03:42Z

VulnerableApplication/Controllers/HomeController.cs

        return "this is not on the coding rules.";
        }
+
+        private static string ChangePassword = "PassWord917231";


CODE_SMELL

The field 'HomeController.ChangePassword' is assigned but its value is never used
See details

TsuyoshiUshio · 2019-07-29T22:03:43Z

VulnerableApplication/Controllers/HomeController.cs

        return "this is not on the coding rules.";
        }
+
+        private static string ChangePassword = "PassWord917231";


CODE_SMELL

Remove this method and declare a constant for this value.
See details

TsuyoshiUshio · 2019-07-29T22:03:44Z

CODE_SMELL

[VulnerableApplication] Mark this assembly with 'System.CLSCompliantAttribute'
See details

TsuyoshiUshio added 13 commits June 15, 2019 21:13

Bad password

6047d8c

Update README.md

31a3cf8

Update README.md

663e8f2

Update README.md

396079f

Update README.md

e944bf6

Update README.md

9bf4899

Update README.md

2d5d418

Update HomeController.cs

9e61bb1

Update README.md

29b147d

Update README.md

acaa2f4

Update very secure information

ef3efc6

Update README.md

f8f3fb2

Update README.md

ff4d5e7

TsuyoshiUshio commented Jul 29, 2019

View reviewed changes

Conversation

TsuyoshiUshio commented Jul 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TsuyoshiUshio commented Jul 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

TsuyoshiUshio commented Jul 29, 2019 •

edited

Loading