-
Notifications
You must be signed in to change notification settings - Fork 118
16kb Aligned React Native #3090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bitmold
wants to merge
21
commits into
develop
Choose a base branch
from
16kb-aligned-reactnative
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+21,052
−45,580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fetches the new aligned binary from Maven instead like a regular Android dependency instead of from the JavaScript project via npm. Therefore no iOS/desktop changes are a part of this PR.
…and remove TODO comments
…ts to pass into node are never freed. - Otherwise cleaned up C++ code with suggestions from clang-tidy
…3.1... notably react 18.3.0 only adds warnings to assist upgrading to react 19, but still they should match
…s the system already does this
…ions dealing with these two vulns: GHSA-mh29-5h37-fv8m GHSA-554w-wpv2-vw27
Collaborator
Author
|
After merging this PR, the APK will appear to be aligned if you run it against Google's 64 bit x86_64/arm64 alignment script: However, this script doesn't pick up |
… sure if this is even used anymore but updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
This bumps react native to 0.77.3, which aligns many native binaries on Android. It contains necessary JavaScript, Android-specific, and iOS-specific changes.
Making this as a draft right now...
This should be merged after the work of #3065 and #3067 has been tested and looks good. Just getting this ready right now. I also need to rebuild the project on iOS and test against other changes that have been merged from the past week, but I expect that to be fine. Will update this once I do though.