16KBAligned JavaScriptCore (libjsc.so) on Android #3066
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fetches the new aligned binary from Maven instead like a regular Android dependency instead of from the JavaScript project via npm. Therefore no iOS/desktop changes are a part of this PR.
bitmold
force-pushed
the
16kb-android-jscore
branch
from
ee9413b to
9d7518a
Compare
islathehut
approved these changes
Jan 20, 2026
Collaborator
Author
Collaborator
Author
|
Closing, it made sense to make this a part of #3090 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change to the Android Gradle project. It replaces the unaligned native binary for javascript core (
libjsc) that Quiet pulled from via JavaScript from an npm module to a newer 16kb aligned build based from Maven (a repository host for Android/Java dependencies). There should be no changes to iOS or Desktop with this PR since it only modifies the Android build script....This PR should't be merged into
developuntil the PR I just opened that lays the groundwork for all the Android alignments has been integrated intodevelop.For the time being, I'm comparing my PR against that branch instead of
developso only the changes to get javascript core aligned are shown as a diff on this PR... Once that PR is merged, I'll remove the DRAFT label on this PR and change the target branch to bedevelop...