Skip to content

Conversation

@stankudrow
Copy link
Contributor

@stankudrow stankudrow commented May 31, 2025

Features:

  • abandon pdm in favour of uv
  • add Python3.14 support
  • move from Makefile to Justfile -> https://github.com/casey/just
  • update GHA workflow files
  • some other chores

Based on the discussion from the #218 .

@stankudrow stankudrow marked this pull request as draft May 31, 2025 17:40
@stankudrow
Copy link
Contributor Author

@Tinche , hello.

Do you need tox for this project if GHA are enabled? If not, I'll remove "tox.ini" file.

@Tinche
Copy link
Owner

Tinche commented May 31, 2025

I'd prefer to keep tox since it can be useful to run a multitude of tests locally for contributors

run: "uv build"
- name: "List result"
run: "ls -l dist"
- name: "Check wheel contents"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe to do something with the following lines in conformance with uv GHA integration.

@stankudrow
Copy link
Contributor Author

@Tinche , hello.

I need your coauthorship with GHA and tox's runner option.

@stankudrow stankudrow marked this pull request as ready for review June 1, 2025 19:53
@Tinche
Copy link
Owner

Tinche commented Jun 19, 2025

Thanks for your efforts Stanley. This turned out to be significantly trickier than I assumed it would. Still not super happy with how the Justfile had to change, but I think this is an issue with tox-uv.

@Tinche Tinche merged commit 6fdc25c into Tinche:main Jun 19, 2025
16 checks passed
stankudrow pushed a commit to stankudrow/aiofiles that referenced this pull request Jun 20, 2025
@stankudrow
Copy link
Contributor Author

Thanks for your efforts Stanley. This turned out to be significantly trickier than I assumed it would. Still not super happy with how the Justfile had to change, but I think this is an issue with tox-uv.

Thank you in helping to finish this PR, I learnt more about tox, good experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants