-
-
Notifications
You must be signed in to change notification settings - Fork 163
Implement the wrap function with the asyncio.to_thread underneath.
#213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implement the wrap function with the asyncio.to_thread underneath.
#213
Conversation
asyncio to thread in the wrapasyncio.to thread in the wrap
asyncio.to thread in the wrapwrap in favour of the new asyncify wrapper.
wrap in favour of the new asyncify wrapper.wrap function.
wrap function.to_coro function with the asyncio.to_thread under -> deprecating the wrap function.
6f98dc2 to
83a4442
Compare
to_coro function with the asyncio.to_thread under -> deprecating the wrap function.to_coro function with the asyncio.to_thread underneath -> deprecating the wrap function.
83a4442 to
4312783
Compare
|
@Tinche , hello. Could you possibly have a look at this PR? |
|
I don't see a ton of value in the |
to_coro function with the asyncio.to_thread underneath -> deprecating the wrap function.wrap function with the asyncio.to_thread underneath.
No problem, but please have another look at this PR:
I hope these changes are enough and still add real value to the project. |
|
@Tinche , hello. This PR is ready for another review:
|
|
@Tinche , good day. I have updated the CHANGELOG and README files, the |
Features:
wrap-> base::asyncio.to_threadjust checkCloses #207 .
Makes the #177 obsolete (actually done by the #209).