Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
b65d8d7
workflows: Add lint for JS and updates
michaelwood Jan 7, 2025
9733631
lib360dataquality/cove: All backend changes for v1 DQT 24/25 project
michaelwood Jan 7, 2025
e3f80aa
.gitignore: Add untracked and node_modules
michaelwood Jan 7, 2025
149b664
cove: frontend: Rewrite frontend v1 DQT 24/25 project
michaelwood Jan 7, 2025
8fa9263
cove: views: Comment out context debugging
michaelwood Jan 7, 2025
058d836
cove: views: Set submission_tool to false when swapping modes
michaelwood Jan 7, 2025
c043277
cove: templates: Split out data conversion errors and additional fields
michaelwood Jan 30, 2025
af30224
cove: templates: Update copy
michaelwood Jan 31, 2025
a554d61
cove: additional_checks: Various fixes
michaelwood Jan 31, 2025
0f31880
lint: Fix flake8
michaelwood Jan 31, 2025
6c14a28
cove: test_browser: Update element Id for conversion errors
michaelwood Feb 3, 2025
e3e3b89
lib360dataquality: Add new cove additional checks
michaelwood Feb 3, 2025
a2ded43
flake8: fix lint
michaelwood Feb 3, 2025
e085dbb
cove: input: Add drag and drop feature
michaelwood Feb 4, 2025
dc6628d
cove: templates: Make sure to pass submission_tool context item
michaelwood Feb 4, 2025
8e6df72
cove: templates: Update comment
michaelwood Feb 5, 2025
c33fc29
lib360dataquality: PlannedDurationNotPresent Fix incorrect logic
michaelwood Feb 5, 2025
373b25f
cove: explore: Move additional_fields to after validity
michaelwood Feb 5, 2025
3dea426
cove: templates: Tidy up and redesign of summary/review page
michaelwood Feb 5, 2025
829b93e
cove: templates: Remove comment about drag and drop
michaelwood Feb 6, 2025
2173177
cove: templates: Avoid confusing disclaimer when validity fails
michaelwood Feb 6, 2025
44c9c46
lib/cove: Add importance flag to various accuracy tests
michaelwood Feb 6, 2025
bfe98f6
cove: views: Sort accuracy tests by importance
michaelwood Feb 6, 2025
0da59a5
cove: views: Move debug comment lower
michaelwood Feb 6, 2025
e7cd079
cove: templates: usefulness Implement new design
michaelwood Feb 6, 2025
2f4b76b
cove: validation_table: Revert design changes and re-add fixes
michaelwood Feb 6, 2025
d52b2ba
cove: additional_checks: Split context output into different categories
michaelwood Feb 7, 2025
70205e1
cove: views: Only attempt to sort quality_accuracy_checks if they exist
michaelwood Feb 7, 2025
02e6591
cove: views: Only enable cache if not in DEBUG mode
michaelwood Feb 7, 2025
32573aa
lib: check_field_present: Capture any rogue non false values
michaelwood Feb 7, 2025
6ecf281
lib: check_field_present: faithfully return the value if no exception
michaelwood Feb 7, 2025
6fc9b1a
lib: threesixtygiving: Don't ignore errors if spreadsheet location fail
michaelwood Feb 7, 2025
2d81e2c
lib360dataquality: threesixtygiving: Rework MultiFunding* tests
michaelwood Feb 7, 2025
3c4ff63
tests: Add importance field to existing test data and add new data
michaelwood Feb 10, 2025
55527ec
cove: templates: Add developer hint for which test is being referenced
michaelwood Feb 10, 2025
a937f62
cove: templates: Make sure "See Where" button doesn't get wrapped
michaelwood Feb 10, 2025
d254e44
lib360dataquality: Add some plausible data looking at for missing data
michaelwood Feb 10, 2025
7398b27
cove: templates: explore_checking: Tidy up title element
michaelwood Feb 10, 2025
0b07abe
cove: templates: Small white space consistency changes
michaelwood Feb 10, 2025
cebc78e
cove: templates: Tidy up conversion errors tab
michaelwood Feb 10, 2025
0386f36
cove: Various small fixes identified during 360 co-working session
michaelwood Feb 10, 2025
42d6498
requirements_cove*: Upgrade all
michaelwood Feb 11, 2025
b9942e3
cove: views: Add back the cache even in debug
michaelwood Feb 26, 2025
0c94a20
lib360dataquality: IncompleteRecipientOrg don't require geoCodeType
michaelwood Feb 26, 2025
13b6d7d
lib360dataquality: BeneficiaryButNotRecipientGeoData allow postalCode
michaelwood Feb 26, 2025
4b0af24
cove: templates: media_card_box: Ensure 3 columns in data review
michaelwood Feb 26, 2025
85c45ac
cove: templates: summary: Remove now redundant sentence
michaelwood Feb 26, 2025
97e7f10
lib360dataquality: Update copy in additional_checks
KDuerden Feb 26, 2025
5a30039
lib360dataquality: Update copy in check_field_present additional checks
KDuerden Feb 27, 2025
0d7ae05
cove: templates: Update copy
KDuerden Feb 27, 2025
2eecc3d
workflows: test: Remove deprecated actions + cache switch ubuntu version
michaelwood Mar 5, 2025
8446289
cove: templates: Add missing message about non-utf8 files
michaelwood Mar 5, 2025
02b0971
cove: tests: Fix existing test_explore_360_url_input cove tests
michaelwood Mar 5, 2025
abc45f8
cove: tests: Remove test_input as we no longer support source_url input
michaelwood Mar 6, 2025
234cce2
cove: tests: Update and improve all existing tests
michaelwood Mar 6, 2025
9102dd2
lib360dataquality: threesixtygiving: misc minor updates
michaelwood Mar 12, 2025
5e27ccb
tests: Add test to check MultiFundingNamesForOrgId
michaelwood Mar 12, 2025
a765693
cove: summary: Correct the named area for conversion
michaelwood Mar 17, 2025
d1c6536
cove: 360-ds Update to latest and update to new compiled css
michaelwood Mar 19, 2025
4b05ee5
cove: Add universal nav
michaelwood Mar 19, 2025
c884f4a
cove: base: Add an alert banner to tell people about the new site
michaelwood Mar 19, 2025
fc99716
cove: input: Remove sample data loading link
michaelwood Mar 19, 2025
a1a70e5
cove: templates: Add getting_further_help to both summary and input
michaelwood Mar 19, 2025
92421a2
cove: test_browser: Remove sample_data_link test as redundant
michaelwood Mar 19, 2025
d7958fb
cove: explore: Add new title copy for critical issue vs issue
michaelwood Mar 19, 2025
ca11d06
cove: templates: additional_checks: Fix new line and non-html render
michaelwood Mar 20, 2025
d3f00f1
lib360dataquality: check_field_present: Make sure to chain up
michaelwood Mar 20, 2025
3387707
cove: test_browser: Update for new copy for PlannedDurationNotPresent
michaelwood Mar 21, 2025
cfeb45c
cove: test_browser: Add basic test for additional_checks page
michaelwood Mar 21, 2025
ba1d147
lib360dataquality: check_field_present: sort out the check_text
michaelwood Mar 21, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"root": true,
"env": {
"browser": true,
"es2021": true,
"jquery": true
},
"plugins": [
"html"
],
"parserOptions": {
"ecmaVersion": "latest"
},
"extends": [
"eslint-config-semistandard"
],
"globals": {
"URI": "readonly"
},
"rules": {
"comma-dangle": "error",
}
}
12 changes: 5 additions & 7 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,17 @@ on: [push, pull_request]

jobs:
build:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- name: Setup python
uses: actions/setup-python@v2
with:
python-version: 3.8
architecture: x64
- uses: actions/cache@v1
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements_dev.txt') }}-${{ matrix.python-version }}
restore-keys: |
${{ runner.os }}-pip-
- run: pip install -r requirements_dev.txt
- run: flake8

- run: npm install
- run: ./node_modules/eslint/bin/eslint.js --ext .js --ext .html cove/cove_360/templates/**
- run: ./node_modules/eslint/bin/eslint.js --ext .js --ext .html cove/cove_360/static/dataexplore/js/**
9 changes: 1 addition & 8 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on: [push, pull_request]

jobs:
build:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
env:
DATA_SUBMISSION_ENABLED: "true"
REGISTRY_PUBLISHERS_URL: ${{secrets.REGISTRY_PUBLISHERS_URL}}
Expand All @@ -20,13 +20,6 @@ jobs:
with:
python-version: ${{ matrix.python-version }}
architecture: x64
- uses: actions/cache@v1
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements_dev.txt') }}-${{ matrix.python-version }}
restore-keys: |
${{ runner.os }}-pip-

- name: Install requirements_cove_dev.txt
run: pip install -r requirements_cove_dev.txt
- name: Install Ubuntu Translation Libraries
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,5 @@ cove/lib/org-ids.json
cove/lib/org-ids.json.lock
chromedriver/
src/
node_modules/
untracked/
2 changes: 1 addition & 1 deletion 360-ds
Submodule 360-ds updated 42 files
+2 −2 README.md
+3,214 −5,009 package-lock.json
+3 −1 src/components/02-elements/anchors/anchors.scss
+12 −0 src/components/02-elements/buttons/buttons.njk
+61 −12 src/components/02-elements/buttons/buttons.scss
+1 −1 src/components/02-elements/cookie-consent/cookie-consent.njk
+0 −1 src/components/02-elements/page-title/page-title.scss
+0 −9 src/components/02-elements/typography/typography.scss
+3 −3 src/components/03-components/bar-chart/bar-chart.njk
+2 −4 src/components/03-components/bar-chart/bar-chart.scss
+26 −0 src/components/03-components/form/form.config.yml
+168 −0 src/components/03-components/form/form.njk
+276 −0 src/components/03-components/form/form.scss
+1 −1 src/components/03-components/search-summary/search-summary.scss
+2 −2 src/components/04-modules/chart-card/chart-card.njk
+2 −2 src/components/04-modules/footer/footer--compact.njk
+2 −2 src/components/04-modules/footer/footer--left.njk
+2 −2 src/components/04-modules/footer/footer.njk
+1 −3 src/components/04-modules/footer/footer.scss
+13 −0 src/components/04-modules/grid/grid.scss
+1 −1 src/components/04-modules/media-card/media-card.scss
+0 −2 src/components/04-modules/prose/prose.scss
+4 −0 src/components/04-modules/search-block/search-block.scss
+1 −0 src/components/04-modules/sort-filter-bar/sort-filter-bar.njk
+6 −0 src/components/04-modules/sort-filter-bar/sort-filter-bar.scss
+0 −1 src/components/04-modules/top-bar/top-bar.scss
+61 −0 src/components/04-modules/universal-nav-bar/universal-nav-bar--item-highlighted.njk
+11 −0 src/components/04-modules/universal-nav-bar/universal-nav-bar.config.yml
+61 −0 src/components/04-modules/universal-nav-bar/universal-nav-bar.njk
+7 −0 src/components/04-modules/universal-nav-bar/universal-nav-bar.readme.md
+157 −0 src/components/04-modules/universal-nav-bar/universal-nav-bar.scss
+1 −0 src/components/06-prototypes/grant-nav/grant-nav.scss
+1 −1 src/project-styles/360-ds/360-ds.scss
+17 −0 src/project-styles/360-ds/custom.scss
+1 −0 src/project-styles/360-ds/main.scss
+67 −1 src/project-styles/grantnav/custom.scss
+1 −1 src/project-styles/grantnav/grantnav.scss
+1 −0 src/project-styles/grantnav/main.scss
+11 −0 src/project-styles/grantnav/widgets.scss
+7 −6 src/project-styles/insights/custom.scss
+0 −3 src/scss/pre/_reset.scss
+11 −0 src/scss/pre/_utils.scss
1 change: 1 addition & 0 deletions cove/cove_360/context_processors.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ def additional_context(request):
return {
"DATA_SUBMISSION_ENABLED": settings.DATA_SUBMISSION_ENABLED,
"DEBUG": settings.DEBUG,
"DISABLE_COOKIE_POPUP": settings.DISABLE_COOKIE_POPUP,
}
Binary file modified cove/cove_360/fixtures/RecipientIndWithoutToIndividualsDetails.xlsx
Binary file not shown.
27 changes: 27 additions & 0 deletions cove/cove_360/fixtures/additional_fields.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"grants": [
{
"id": "360G-sampletrust-105177/Z/14/Z",
"awardDate": "2024-12-30",
"amountAwarded": 10,
"url": "http://example.com",
"title": "test",
"currency": "GBP",
"description": "test",
"AdditionalField": "2",
"CheckMicOne": "two",
"recipientOrganization": [
{
"id": "GB-323242-test",
"name": "Example Project Limited"
}
],
"fundingOrganization": [
{
"id": "GB-323242-test",
"name": "Example Project Limited"
}
]
}
]
}
25 changes: 25 additions & 0 deletions cove/cove_360/fixtures/duration_usefulness.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"grants": [
{
"id": "360G-sampletrust-105177/Z/14/Z",
"awardDate": "2024-12-30",
"amountAwarded": 10,
"url": "http://example.com",
"title": "test",
"currency": "GBP",
"description": "test",
"recipientOrganization": [
{
"id": "GB-323242-test",
"name": "Example Project Limited"
}
],
"fundingOrganization": [
{
"id": "GB-323242-test",
"name": "Example Project Limited"
}
]
}
]
}
57 changes: 57 additions & 0 deletions cove/cove_360/fixtures/multiple_funder_names_org_ids.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
{
"grants": [
{
"id": "360G-sampletrust-105177/Z/14/Z",
"awardDate": "2024-12-30",
"amountAwarded": 10,
"url": "http://example.com",
"title": "test",
"currency": "GBP",
"description": "test",
"plannedDates": [
{
"duration": 30
}
],
"recipientOrganization": [
{
"id": "GB-323242-test",
"name": "Example Project Limited"
}
],
"fundingOrganization": [
{
"id": "GB-12345-test",
"name": "Example Funder Limited"
}
]
},
{
"id": "360G-sampletrust-123452",
"awardDate": "2024-12-30",
"amountAwarded": 10,
"url": "http://example.com",
"title": "test two",
"currency": "GBP",
"description": "test two",
"plannedDates": [
{
"duration": 30
}
],
"recipientOrganization": [
{
"id": "GB-323242-test",
"name": "Example Project Limited"
}
],
"fundingOrganization": [
{
"id": "GB-54321-test",
"name": "Example Funder Limited"
}
]
}

]
}
3 changes: 2 additions & 1 deletion cove/cove_360/fixtures/publishers.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
"self_publish": {
"enabled": true,
"authorised_domains": [
"test-data.360dev1.vs.mythic-beasts.com"
"test-data.360dev1.vs.mythic-beasts.com",
"www.threesixtygiving.org"
]
}
}
Expand Down
Loading