Mw/dqt 2024 #117
Merged
Mw/dqt 2024 #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelwood
force-pushed
the
mw/dqt-2024
branch
from
db2853a to
120d76f
Compare
michaelwood
force-pushed
the
mw/dqt-2024
branch
from
c3a5876 to
c4e0f78
Compare
Update the ubuntu version and remove redundant cache action.
* Move cove tests into their own folder * Fix issue with cookie popup breaking test and generally being annoying on developer instance set DISABLE_COOKIE_POPUP to disable cookie popup * Add option to use Chrome not in headless mode for browser tests * Fix all tests for incoming copy and frontend layout changes * Remove and tidy up a lot of the test code * Convert to new selenium API By. etc * additional_test Add categories to these tests (LOCATION, ORGANISATIONS...) * Add new additional_test * Remove Grants table display with settings.GRANTS_TABLE this is no longer going to be in use but is provided via lib-cove-* * Add feature to switch between data submission and quality checking * Improve error handling of additional_test failures * Abstract out the additional_test class AdditionalTest for reuse * Add new entry points for data submission urls * Fix index error in create_grant_dates_dict when test data doesn't contain required information which isn't being tested for * Wrap cove_tags to override template values in lib-cove-web * Add a way to work out which additional tests have passed
* Implement new design. Including experimental features TBD in v2 of this project. * Remove dependency on bootstrap * Remove Jquery * polyfill some of the lib-cove-web dependency introduced by lib-cove-web * Start of a component structure to templates * Overrides for almost all lib-cove-web templates - for full authorship see: https://github.com/OpenDataServices/lib-cove-web/tree/main/cove/templates
When swapping between submission and dqt mode make sure to set submission_tool to false. Fixes: #131
Split these into their own dynamically loaded tabs. This is part of an effort to make the summary area more concise.
- Fix incorrect base template - Fix no heading text for check_field_present additional_check - Refactor a shared class into additional_checks to be used by threesixtygiving checks and check_field_present
(2024 dqt-8/9/10)
This speeds up testing and is generally a useful feature
Fixes issue where the correct text/mode wasn't working.
This seems a more logical position for it as validity is the highest in the hierarchy.
Keep this as a secret feature as really requires some additional design work.
Also make validity results output consistent with others. (KD-004)
Rework the accuracy table to new design. KD-005/DQT-011
Implement new design for usefulness opportunities (KD-007). Also fix consistency on capitalisation and copy on usefulness table.
Various edits to additional checks text
Update copy in duration check test
Adding and changing copy for new DQT
This was missing from the redesign
Fix browser tests for new copy and changed design.
Convert these tests into browser based tests to be able to input the data via selenium and check for the errors.
Swap the class name of MultiFundingNamesForOrgId with MultiFundingOrgIdsForName to be correct way around. Remove TODOs for copy as these have been done now
Member
Author
|
@R2ZER0 Now ready for review please |
Also remove output added for debugging conversion status
This is for the global nav changes
Co-authored-by: Myles Lewando <myles.lewando@opendataservices.coop>
michaelwood
force-pushed
the
mw/dqt-2024
branch
from
9fe046b to
c884f4a
Compare
We no longer have this feature so no need to test it!
We can mark these strings as safe and allow the html contained within them to be rendered, we also don't want the new lines to be inserted into the page from the python.
The heading and message weren't being shown from the subclass as the correct overrides weren't in place
This page was untested so do a check that it loads correctly with some expected content
R2ZER0
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is v1 of the new DQT