Add os-families and os-families-exclude configuration option#29
Merged
asgrim merged 1 commit intoThePHPF:mainfrom Dec 9, 2024
Merged
Add os-families and os-families-exclude configuration option#29asgrim merged 1 commit intoThePHPF:mainfrom
os-families and os-families-exclude configuration option#29asgrim merged 1 commit intoThePHPF:mainfrom
Conversation
asgrim
reviewed
Nov 20, 2024
alexandre-daubois
force-pushed
the
os-families-opt
branch
2 times, most recently
from
435d100 to
4b8ec59
Compare
alexandre-daubois
changed the title
os-families-exclude configuration optionos-families and os-families-exclude configuration option
alexandre-daubois
force-pushed
the
os-families-opt
branch
from
4b8ec59 to
8e97f30
Compare
asgrim
reviewed
Nov 28, 2024
Collaborator
asgrim
left a comment
asgrim
left a comment
There was a problem hiding this comment.
Thanks, I just proposed a couple improvements to field descriptions for clarity.
alexandre-daubois
force-pushed
the
os-families-opt
branch
from
8e97f30 to
5925336
Compare
Contributor
Author
|
Indeed way better. Thanks! Should option names be surrounded with quotes in the description? Both ways suit me. |
asgrim
reviewed
Nov 28, 2024
Collaborator
No strong preference :) |
alexandre-daubois
force-pushed
the
os-families-opt
branch
from
5925336 to
d62b20e
Compare
alexandre-daubois
force-pushed
the
os-families-opt
branch
from
d62b20e to
f9d9a55
Compare
Collaborator
|
This needs a corresponding PR to Composer to be merged, otherwise this LGTM 👍 |
Collaborator
|
Thanks @alexandre-daubois |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the option definition for issue php/pie#106, once the name is confirmed.