Add support for os-families-exclude in extensions composer.json#116
Merged
Add support for os-families-exclude in extensions composer.json#116
os-families-exclude in extensions composer.json#116Conversation
93521d0 to
16b8734
Compare
os-families in extensions composer.jsonos-families-exclude in extensions composer.json
a303ebf to
71003c8
Compare
asgrim
requested changes
Nov 20, 2024
51387f8 to
0c2998a
Compare
Member
Author
|
Revamped the whole PR to address your comments.
|
0c2998a to
69bed8b
Compare
69bed8b to
cc4cdf8
Compare
Contributor
|
This is great, love to exclude windows. |
cc4cdf8 to
2926ac4
Compare
… `composer.json`
2926ac4 to
f934832
Compare
asgrim
reviewed
Nov 28, 2024
Member
Author
|
Remaining CS warnings should be fixed once composer/composer#12218 is merged |
03d24dc to
afdcbab
Compare
Contributor
|
PR composer/composer#12218 is now merged; please can you update the composer req, that should fix the static analysis |
afdcbab to
1fd01f0
Compare
1fd01f0 to
8110e8c
Compare
Member
Author
|
Here you go, all green! 🙂 |
asgrim
approved these changes
Dec 9, 2024
Contributor
asgrim
left a comment
There was a problem hiding this comment.
Thanks @alexandre-daubois
|
It's now tagged as part of composer 2.8.4 |
Contributor
|
Thanks @Seldaek ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #106
Allows to specify OS families which the extension is incompatible with:
When the syntax is validated, I'll create a PR in Composer to allow the new key in the
Package::$phpExtproperty.Related to ThePHPF/pie-design#29