Skip to content

[IRN-6174] [BpkCardList] - Child components all same height #3973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alex (rabisse) wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[IRN-6174] [BpkCardList] - Child components all same height #3973

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
30c3049
IRN-6174 BpkCardList Height Scroll
rabisse Sep 16, 2025
eda4e4c
remove scroll stuff
rabisse Sep 25, 2025
5c447bc
remove scroll stuff2
rabisse Sep 25, 2025
5e15486
Merge branch 'main' into IRN-6174_BpkCardList_HeightScroll
rabisse Sep 25, 2025
03d01e4
lol
rabisse Sep 26, 2025
fdd1aa2
min-height
rabisse Sep 26, 2025
5db890f
Merge branch 'main' into IRN-6174_BpkCardList_HeightScroll
rabisse Sep 26, 2025
6c11bea
back to height
rabisse Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@
}
}
}

> * {
height: 100%;
Copy link
Contributor

@kerrie-wu kerrie-wu Sep 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of relying on > * or hardcoding .bpk-card, could we wrap children in a neutral wrapper
(e.g. <div className="bpk-card-slot">{card}</div>). This way the CSS can safely target .bpk-card-slot without depending on the child type, which makes the rule more explicit and avoids unintended side effects.

}
}
}

Expand Down
Loading