-
Notifications
You must be signed in to change notification settings - Fork 203
[IRN-6174] [BpkCardList] - Child components all same height #3973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the BpkCardList component to enable horizontal scrolling on all screen sizes and ensures child elements maintain consistent height. The changes move scrolling behavior from mobile-only to all viewports and add height constraints.
- Enable horizontal scrolling on all screen sizes (not just mobile)
- Add webkit touch scrolling support at the component level
- Ensure child elements fill the available height
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/bpk-component-card-list/src/BpkCardListRowRail/BpkCardListCarousel.module.scss
Show resolved
Hide resolved
|
Visit https://backpack.github.io/storybook-prs/3973 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3973 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3973 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3973 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3973 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3973 to see this build running in a browser. |
| } | ||
|
|
||
| > * { | ||
| height: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of relying on > * or hardcoding .bpk-card, could we wrap children in a neutral wrapper
(e.g. <div className="bpk-card-slot">{card}</div>). This way the CSS can safely target .bpk-card-slot without depending on the child type, which makes the rule more explicit and avoids unintended side effects.
Making all the child components the same height
Remember to include the following changes:
[Clover-123][BpkButton] Updating the colourREADME.md(If you have created a new component)README.md