Skip to content

Account for empty variant arrays in parser #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Grimeh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Account for empty variant arrays in parser #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ShaderStripperVariantCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,19 @@ public override void Initialize(){

// Move to variants contents (skip current line, "second:" and "variants:")
i += 3;

// it's possible for the variants array to be empty (represented by `variants: []`)
if (i >= yaml.Count) {
// this was the final entry, we've reached EOF
break;
}

if (GetYamlIndent(yaml[i]) == indent) {
// the variants array was empty and we're now on the `- first:` line of the next entry
i -= 1; // decrement here because the loop will increment
continue;
}

indent = GetYamlIndent(yaml[i]);
var sv = new ShaderVariantCollection.ShaderVariant();
for (; i<yaml.Count; ++i){
Expand Down