Account for empty variant arrays in parser#12
Open
Grimeh wants to merge 1 commit intoSixWays:masterfrom
Open
Conversation
It's possible for entries in `.shadervariants` assets to have an empty variants array. Eg. `variants: []`. This causes the parser to go out-of-bounds in the `yaml` list when the final entry has an empty variants array. When not the final entry, it probably causes the next entry to be parsed incorrectly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible for entries in
.shadervariantsassets to have an empty variants array. Eg.variants: [].This causes the parser to go out-of-bounds in the
yamllist when the final entry has an empty variants array. When not the final entry, it probably causes the next entry to be parsed incorrectly.Example of empty variant array: