Skip to content

Improve error message #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisBr merged 1 commit into from
Jun 11, 2025
Merged

Improve error message #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ruby/lib/minitest/queue/runner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def report_command

unless supervisor.wait_for_workers { display_warnings(supervisor.build) }
unless supervisor.queue_initialized?
abort! "No master was elected. Did all workers crash?", 40
abort! "No leader was elected. This typically means no worker was able to start. Were there any errors during application boot?", 40
end

unless supervisor.exhausted?
Expand Down
2 changes: 1 addition & 1 deletion ruby/lib/rspec/queue.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ def call(options, stdout, stderr)

unless supervisor.wait_for_workers
unless supervisor.queue_initialized?
abort! "No master was elected. Did all workers crash?"
abort! "No leader was elected. This typically means no worker was able to start. Were there any errors during application boot?"
end

unless supervisor.exhausted?
Expand Down
2 changes: 1 addition & 1 deletion ruby/test/integration/minitest_redis_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ def test_all_workers_died
assert_empty err
expected = <<~EXPECTED
Waiting for workers to complete
No master was elected. Did all workers crash?
No leader was elected. This typically means no worker was able to start. Were there any errors during application boot?
EXPECTED
assert_equal expected.strip, normalize(out.lines[0..2].join.strip)
end
Expand Down
Loading