Conversation
ChrisBr
force-pushed
the
cbruckmayer/improve-error-message
branch
from
5b7a48b to
a073283
Compare
casperisfine
approved these changes
Jun 10, 2025
ChrisBr
force-pushed
the
cbruckmayer/improve-error-message
branch
from
a073283 to
6ab6c01
Compare
ruby/lib/minitest/queue/runner.rb
Outdated
| unless supervisor.wait_for_workers { display_warnings(supervisor.build) } | ||
| unless supervisor.queue_initialized? | ||
| abort! "No master was elected. Did all workers crash?", 40 | ||
| abort! "No leader was elected. This typically means no worker was able to start (e.g. application failed to initialize).", 40 |
There was a problem hiding this comment.
Is there something we could add to direct developers where to look? Something like were there any errors on application boot?
Contributor
Author
There was a problem hiding this comment.
What about
No leader was elected. This typically means no worker was able to start. Were there any errors during application boot?
?
Contributor
There was a problem hiding this comment.
I think ^ makes sense, only thought it maybe we include that the errors would be in the test jobs
No leader was elected. This typically means no worker was able to start. Check the test job logs for errors on application boot.
ChrisBr
force-pushed
the
cbruckmayer/improve-error-message
branch
from
6ab6c01 to
d25df63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found that this error message is often confusing for developers which fail to detect that their change causes the application to crash (and hence no leader gets elected).