Merged
Conversation
ChrisBr
force-pushed
the
cbruckmayer/make-setnx-atomic-v2
branch
2 times, most recently
from
c061678 to
0612cfb
Compare
casperisfine
approved these changes
May 15, 2025
ChrisBr
force-pushed
the
cbruckmayer/make-setnx-atomic-v2
branch
from
0612cfb to
edcce13
Compare
ChrisBr
force-pushed
the
cbruckmayer/make-setnx-atomic-v2
branch
from
edcce13 to
99df085
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setnxwhich we use during leader election is currently not safe to retry via Redis reconnect_attempts as the command could succeed on server side but we run into a client timeout. In this case, any subsequentsetnxcalls will return false and leader election will fail.Instead we're now setting a uniq value for setup and compare it when we fail.