Skip to content

Make leader election idempotent #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisBr merged 1 commit into from
May 15, 2025
Merged

Make leader election idempotent #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ruby/lib/ci/queue/redis/worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,14 @@ def try_to_reserve_lost_test
def push(tests)
@total = tests.size

if @master = redis.setnx(key('master-status'), 'setup')
# We set a unique value (worker_id) and read it back to make "SET if Not eXists" idempotent in case of a retry.
value = key('setup', worker_id)
_, status = redis.pipelined do |pipeline|
pipeline.set(key('master-status'), value, nx: true)
pipeline.get(key('master-status'))
end

if @master = (value == status)
puts "Worker electected as leader, pushing #{@total} tests to the queue."
puts

Expand Down
Loading