-
Notifications
You must be signed in to change notification settings - Fork 1
Add information on how to use LA100-P #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Added instructions for creation of a new project targeting the alternative processor all new AMDS mainboards are populated with.
Alternative Processor Firmware Update Process
Add Compiler Optimization instructions to README
|
Thanks @noguchi-takahiro, I'll have you do a round of revision with @ngadiyar93. Then I am realizing that we'll need you to make these same changes here as well --> source is here. |
CurrentCard/docs/README.md
Outdated
|
|
||
| ### Current Sensor | ||
| LEM LA 55-P current sensor is selected for this design, as it is the only sensor available from LEM with an open aperture and PC pins that can measure +/-55A. | ||
| LEM LA 55-P and LA 100-P current sensors are selected for this design, as it is the only sensor available from LEM with an open aperture and PC pins that can measure +/-55A and +/-150A, respectively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noguchi-takahiro this sentence as is isn't quite grammatically correct.
Can you improve it to say that Either LA-55P or LA 100-P can be used with this design based on the sensing range desired (and provide the sensing range as you are currently doing).
Also please include a note saying that LA-100P has a variant SP/13 which has a different gain that users must be careful about when ordering.
ngadiyar93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noguchi-takahiro Thank you for updating the document and the BOM.
I have a minor change request that I have indicated in-line. Please let me know once you have fixed it.
|
Thanks, @ngadiyar93 I changed the sentences that you mentioned. And please review it and let me know of further improvements and requests. |
ngadiyar93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noguchi-takahiro Thank you for updating the document.
I have left you a couple of items which should be pretty quick to address.
CurrentCard/docs/README.md
Outdated
|
|
||
| ### Current Sensor | ||
| LEM LA 55-P current sensor is selected for this design, as it is the only sensor available from LEM with an open aperture and PC pins that can measure +/-55A. | ||
| LEM LA 55-P or LA 100-P current sensors are selected and can be used for this design based on the sensing range desired. They are available from LEM with an open aperture and PC pins. LEM LA 55-P and LA 100-P can measure +/-55A and +/-150A, respectively. Note that the LA100 series also has these variants, LA100-P/SP13 and LA100-TP, which have different gains that users must be careful about when ordering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noguchi-takahiro can you update this line as follows:
Based on the sensing range desired, the current measurement card can use either LA 55-P or LA 100-P from LEM. These sensors have an open aperture and PC pins. The LA 55-P can measure +/-55A while the LA 100-P can measure +/-150A.
CurrentCard/docs/README.md
Outdated
|
|
||
| ### Current Sensor | ||
| LEM LA 55-P current sensor is selected for this design, as it is the only sensor available from LEM with an open aperture and PC pins that can measure +/-55A. | ||
| LEM LA 55-P or LA 100-P current sensors are selected and can be used for this design based on the sensing range desired. They are available from LEM with an open aperture and PC pins. LEM LA 55-P and LA 100-P can measure +/-55A and +/-150A, respectively. Note that the LA100 series also has these variants, LA100-P/SP13 and LA100-TP, which have different gains that users must be careful about when ordering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noguchi-takahiro Can you add the Note about the LA 100 series variants in a separate line with the word "Note" in bold as follows (please refine the language to be better than what I am saying):
Note: The LA 100 series has three variants LA 100-P, LA 100-P/SP13, and LA 100-TP. The sensor gains of each of these variants are different, which has implications in the choice of the burden resistor. The rest of this document is specific to the LA 100-P variant.
CurrentCard/docs/README.md
Outdated
| The open aperture was a requirement as it allows for the range to be easily scaled down just by adding turns to the primary. | ||
| The LA 55-P is a closed loop compensated hall effect transducer that has an accuracy of +/-0.65% and linearity of <0.15% which is quite good compared to other sensors from LEM. | ||
| It has an excellent bandwidth of 200khz and a low impedance current output that is inherently more immune to noise than a high impedance voltage output. | ||
| The LA 55-P is a closed loop compensated hall effect transducers that has an accuracy of +/-0.65% and linearity of <0.15% which is quite good compared to other sensors from LEM. The LA 100-P has an accuracy of +/-0.45% and linearity of <0.15%. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transducers, please update to be transducer since it is singular.
|
Thank you, @ngadiyar93. Please review it again. We also need to address this below.
|
|
@elsevers this PR closed due to deleting its target branch. Do you still want this content to be merged? |
|
Thanks @npetersen2. Good catch. I did not mean to close this PR. |
This PR is to add information on how to use LA100-P to AMDS documentation.
I added;
@ngadiyar93, please review these changes above.