Skip to content

Refactor CI workflow #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ServeurpersoCom merged 1 commit into from
Mar 12, 2026
Merged

Refactor CI workflow #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions .github/workflows/ci-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,6 @@ jobs:
sudo apt-get update -qq
sudo apt-get install -y -qq clang-format clang-tidy cppcheck

- name: Check trailing whitespace
continue-on-error: true
run: |
if grep -rIn --exclude-dir=.git --exclude="*.md,*.log" "[[:blank:]]$" .; then
echo "Trailing whitespace detected!"
exit 1
fi

- name: Run clang-format (check mode)
run: |
find . \
Expand All @@ -72,9 +64,14 @@ jobs:
run: |
cppcheck --enable=all --error-exitcode=1 --inline-suppr \
--suppress=missingIncludeSystem \
--suppress=unusedFunction \
--suppress=missingInclude \
--suppress=cstyleCast \
--suppress=constVariable \
-i ggml -i build -i .git \
--suppress=constVariablePointer \
--suppress=constParameterPointer \
--suppress=variableScope \
--suppress=uselessCallsSubstr \
--suppress=useStlAlgorithm \
--suppress=shiftNegativeLHS \
Comment on lines +70 to +75
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Consider keeping shiftNegativeLHS check enabled.

Most of these suppressions are reasonable style preferences. However, shiftNegativeLHS warns about left-shifting negative values, which is undefined behavior in C/C++. Suppressing this globally could mask real bugs in signal processing or bit manipulation code.

If specific instances are false positives, consider using inline suppressions (// cppcheck-suppress shiftNegativeLHS) at those locations rather than a global suppression.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci-build.yml around lines 70 - 75, The global cppcheck
suppression "shiftNegativeLHS" should be removed from the CI config to avoid
hiding undefined left-shift-of-negative-value bugs; delete the
"--suppress=shiftNegativeLHS" entry and instead add targeted inline suppressions
(use comments like "// cppcheck-suppress shiftNegativeLHS") at the specific
functions or files that are known false positives, or add per-file suppressions
in the cppcheck config for those exact sources; search for bit-manipulation or
signal-processing functions and update their source locations with the inline
suppress comment so the rest of the codebase remains checked for genuine
shiftNegativeLHS issues.

Copy link
Contributor Author

@lmangani lmangani Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is up to @ServeurpersoCom

Copy link
Contributor

@coderabbitai coderabbitai bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

-i ggml -i build -i .git -i mp3 \
.
Loading